Add support import for aws_waf_byte_match_set resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9212

Release note for CHANGELOG:

resource/aws_waf_byte_match_set: Support resource import

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafByteMatchSet_'

=== RUN   TestAccAWSWafByteMatchSet_basic
=== PAUSE TestAccAWSWafByteMatchSet_basic
=== CONT  TestAccAWSWafByteMatchSet_basic
--- PASS: TestAccAWSWafByteMatchSet_basic (52.29s)
=== RUN   TestAccAWSWafByteMatchSet_changeNameForceNew
=== PAUSE TestAccAWSWafByteMatchSet_changeNameForceNew
=== CONT  TestAccAWSWafByteMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (89.50s)
=== RUN   TestAccAWSWafByteMatchSet_changeTuples
=== PAUSE TestAccAWSWafByteMatchSet_changeTuples
=== CONT  TestAccAWSWafByteMatchSet_changeTuples
--- FAIL: TestAccAWSWafByteMatchSet_changeTuples (81.89s)
    testing.go:569: Step 1 error: After applying this step and refreshing, the plan was not empty:
        
        DIFF:
        
        UPDATE: aws_waf_byte_match_set.byte_set
          byte_match_tuples.#:                       "2" => "2"
          byte_match_tuples.0.field_to_match.#:      "1" => "1"
          byte_match_tuples.0.field_to_match.0.data: "" => "GET"
          byte_match_tuples.0.field_to_match.0.type: "METHOD" => "METHOD"
          byte_match_tuples.0.positional_constraint: "CONTAINS_WORD" => "CONTAINS_WORD"
          byte_match_tuples.0.target_string:         "blah" => "blah"
          byte_match_tuples.0.text_transformation:   "URL_DECODE" => "URL_DECODE"
          byte_match_tuples.1.field_to_match.#:      "1" => "1"
          byte_match_tuples.1.field_to_match.0.data: "referer" => "referer"
          byte_match_tuples.1.field_to_match.0.type: "HEADER" => "HEADER"
          byte_match_tuples.1.positional_constraint: "CONTAINS" => "CONTAINS"
          byte_match_tuples.1.target_string:         "badrefer1" => "badrefer1"
          byte_match_tuples.1.text_transformation:   "NONE" => "NONE"
          id:                                        "7fe3c5d6-bbc4-474d-84dc-0e60b3000421" => "7fe3c5d6-bbc4-474d-84dc-0e60b3000421"
          name:                                      "byteMatchSet-y30mt" => "byteMatchSet-y30mt"
        
        
        
        STATE:
        
        aws_waf_byte_match_set.byte_set:
          ID = 7fe3c5d6-bbc4-474d-84dc-0e60b3000421
          provider = provider.aws
          byte_match_tuples.# = 2
          byte_match_tuples.0.field_to_match.# = 1
          byte_match_tuples.0.field_to_match.0.data = 
          byte_match_tuples.0.field_to_match.0.type = METHOD
          byte_match_tuples.0.positional_constraint = CONTAINS_WORD
          byte_match_tuples.0.target_string = blah
          byte_match_tuples.0.text_transformation = URL_DECODE
          byte_match_tuples.1.field_to_match.# = 1
          byte_match_tuples.1.field_to_match.0.data = referer
          byte_match_tuples.1.field_to_match.0.type = HEADER
          byte_match_tuples.1.positional_constraint = CONTAINS
          byte_match_tuples.1.target_string = badrefer1
          byte_match_tuples.1.text_transformation = NONE
          name = byteMatchSet-y30mt
=== RUN   TestAccAWSWafByteMatchSet_noTuples
=== PAUSE TestAccAWSWafByteMatchSet_noTuples
=== CONT  TestAccAWSWafByteMatchSet_noTuples
--- PASS: TestAccAWSWafByteMatchSet_noTuples (41.12s)
=== RUN   TestAccAWSWafByteMatchSet_disappears
=== PAUSE TestAccAWSWafByteMatchSet_disappears
=== CONT  TestAccAWSWafByteMatchSet_disappears
--- PASS: TestAccAWSWafByteMatchSet_disappears (48.04s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	138.181s

...

[DrFaust92]

FYI, TestAccAWSWafByteMatchSet_changeTuples seems ro fails regardless of the change

[bflad]

LGTM, thanks @DrFaust92 🚀

(Same, unrelated failure)

--- PASS: TestAccAWSWafByteMatchSet_noTuples (21.34s)
--- FAIL: TestAccAWSWafByteMatchSet_changeTuples (33.66s)
--- PASS: TestAccAWSWafByteMatchSet_basic (36.76s)
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (39.74s)
--- PASS: TestAccAWSWafByteMatchSet_disappears (48.34s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!