Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support import for aws_wafregional_web_acl resource #9248

Conversation

teraken0509
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference #9212

Release note for CHANGELOG:

resource/aws_wafregional_web_acl: Support resource import

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSWafRegionalWebAcl_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSWafRegionalWebAcl_ -timeout 120m
=== RUN   TestAccAWSWafRegionalWebAcl_basic
=== PAUSE TestAccAWSWafRegionalWebAcl_basic
=== RUN   TestAccAWSWafRegionalWebAcl_createRateBased
=== PAUSE TestAccAWSWafRegionalWebAcl_createRateBased
=== RUN   TestAccAWSWafRegionalWebAcl_createGroup
=== PAUSE TestAccAWSWafRegionalWebAcl_createGroup
=== RUN   TestAccAWSWafRegionalWebAcl_changeNameForceNew
=== PAUSE TestAccAWSWafRegionalWebAcl_changeNameForceNew
=== RUN   TestAccAWSWafRegionalWebAcl_changeDefaultAction
=== PAUSE TestAccAWSWafRegionalWebAcl_changeDefaultAction
=== RUN   TestAccAWSWafRegionalWebAcl_disappears
=== PAUSE TestAccAWSWafRegionalWebAcl_disappears
=== RUN   TestAccAWSWafRegionalWebAcl_noRules
=== PAUSE TestAccAWSWafRegionalWebAcl_noRules
=== RUN   TestAccAWSWafRegionalWebAcl_changeRules
=== PAUSE TestAccAWSWafRegionalWebAcl_changeRules
=== RUN   TestAccAWSWafRegionalWebAcl_LoggingConfiguration
=== PAUSE TestAccAWSWafRegionalWebAcl_LoggingConfiguration
=== CONT  TestAccAWSWafRegionalWebAcl_basic
=== CONT  TestAccAWSWafRegionalWebAcl_LoggingConfiguration
=== CONT  TestAccAWSWafRegionalWebAcl_changeNameForceNew
=== CONT  TestAccAWSWafRegionalWebAcl_createGroup
=== CONT  TestAccAWSWafRegionalWebAcl_createRateBased
=== CONT  TestAccAWSWafRegionalWebAcl_noRules
=== CONT  TestAccAWSWafRegionalWebAcl_changeRules
=== CONT  TestAccAWSWafRegionalWebAcl_disappears
=== CONT  TestAccAWSWafRegionalWebAcl_changeDefaultAction
--- PASS: TestAccAWSWafRegionalWebAcl_noRules (55.64s)
--- PASS: TestAccAWSWafRegionalWebAcl_disappears (73.04s)
--- PASS: TestAccAWSWafRegionalWebAcl_createGroup (80.93s)
--- PASS: TestAccAWSWafRegionalWebAcl_basic (89.51s)
--- PASS: TestAccAWSWafRegionalWebAcl_createRateBased (91.06s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeRules (95.57s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeNameForceNew (112.68s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeDefaultAction (114.04s)
--- PASS: TestAccAWSWafRegionalWebAcl_LoggingConfiguration (224.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	224.200s

@teraken0509 teraken0509 requested a review from a team July 5, 2019 16:09
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/waf Issues and PRs that pertain to the waf service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 5, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 5, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one little copy-paste typo, which will get fixed on merge. 😄 Thanks, @kterada0509 🚀

--- PASS: TestAccAWSWafRegionalWebAcl_noRules (39.48s)
--- PASS: TestAccAWSWafRegionalWebAcl_basic (51.75s)
--- PASS: TestAccAWSWafRegionalWebAcl_disappears (55.51s)
--- PASS: TestAccAWSWafRegionalWebAcl_createGroup (59.58s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeDefaultAction (69.08s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeRules (85.58s)
--- PASS: TestAccAWSWafRegionalWebAcl_createRateBased (88.09s)
--- PASS: TestAccAWSWafRegionalWebAcl_changeNameForceNew (108.07s)
--- PASS: TestAccAWSWafRegionalWebAcl_LoggingConfiguration (120.86s)


## Import

WAF Regional Rule Group can be imported using the id, e.g.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small copy-paste typo 😎

Suggested change
WAF Regional Rule Group can be imported using the id, e.g.
WAF Regional Web ACL can be imported using the id, e.g.

@bflad bflad added this to the v2.19.0 milestone Jul 5, 2019
@bflad bflad merged commit 2aca061 into hashicorp:master Jul 5, 2019
bflad added a commit that referenced this pull request Jul 5, 2019
@bflad
Copy link
Contributor

bflad commented Jul 11, 2019

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
@teraken0509 teraken0509 deleted the feature/add-import-support-for-aws_wafregional_web_acl-resource branch March 5, 2020 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants