Fix various SpecialReportAlt bugs #26003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannakok
commented
Mar 23, 2023
| @@ -415,7 +415,7 @@ $pillars: ( | |||
| background-color: $special-report-alt-faded; | |||
|
|
|||
| .fc-item__container.u-faux-block-link--hover { | |||
| background-color: darken($special-report-alt-faded, 2%); | |||
| background-color: darken($special-report-alt-pastel, 5%); | |||
There was a problem hiding this comment.
Hover state of feature
| Before | After |
|---|---|
 |
 |
 |
 |
ioannakok
commented
Mar 23, 2023
| .fc-item--pillar-special-report-alt { | ||
| .fc-item__meta { | ||
| .inline-icon { | ||
| fill: $special-report-alt-dark; |
There was a problem hiding this comment.
SVGs in meta (like the clock and the comment bubble) outside the palette
| Before | After |
|---|---|
 |
 |
 |
 |
ioannakok
commented
Mar 23, 2023
| .fc-item__timestamp, | ||
| .fc-trail__count--commentcount { | ||
| background-color: darken($special-report-alt-pastel, 5%); | ||
|
|
There was a problem hiding this comment.
Type comment with pillar news and special-report-alt (non-hover & hover)
| Before | After |
|---|---|
 |
 |
 |
 |
ioannakok
commented
Mar 23, 2023
| } | ||
| } | ||
|
|
||
| .fc-item--pillar-special-report-alt { | ||
| .fc-item__container > .fc-item__meta { | ||
| @include multiline(3, rgba(60, 60, 60, .3)); | ||
| @include multiline(3, rgba(112, 112, 112, .3)); |
There was a problem hiding this comment.
Fixes the grey lines for opinion cards to be the same grey as all the lines / borders in the palette
ioannakok
commented
Mar 23, 2023
| @@ -11,3 +11,4 @@ | |||
| @include overide-interview-headline-colours(arts, $culture-dark, $culture-pastel); | |||
| @include overide-interview-headline-colours(lifestyle, $lifestyle-dark, $news-pastel); | |||
| @include overide-interview-headline-colours(special-report, #ffffff, #ffffff); | |||
| @include overide-interview-headline-colours(special-report-alt, $special-report-alt-dark, $special-report-alt-dark); | |||
ioannakok
commented
Mar 23, 2023
|
|
||
| @if $pillar == special-report-alt { | ||
| background-color: darken($color1, 2%); | ||
| background-color: darken($special-report-alt-pastel, 5%); | ||
| } @else { | ||
| background-color: darken($color1, 5%); |
ioannakok
commented
Mar 23, 2023
|
|
||
| @if $pillar == special-report-alt { | ||
| background-color: darken($color1, 2%); | ||
| background-color: darken($special-report-alt-pastel, 5%); |
ioannakok
commented
Mar 23, 2023
| @@ -121,7 +121,7 @@ | |||
|
|
|||
| &:hover, | |||
| .u-faux-block-link--hover { | |||
| background-color: darken($special-report-alt-faded, 2%); | |||
| background-color: darken($special-report-alt-pastel, 5%); | |||
Co-authored-by: Olly Namey <olly.namey@guardian.co.uk>
Co-authored-by: Olly Namey <olly.namey@guardian.co.uk>
Co-authored-by: Olly Namey <olly.namey@guardian.co.uk>
ioannakok
force-pushed
the
ioanna/various-special-report-alt-bugs
branch
from
4bc000e
to
b47b675
Compare
ioannakok
changed the title
bryophyta
approved these changes
Mar 23, 2023
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @ioannakok 20 minutes and 43 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes various visual bugs in SpecialReportAlt fronts cards:
Does this change need to be reproduced in dotcom-rendering ?
Screenshots
This is a more general screenshot but more detailed can be found in PR comments.
What is the value of this and can you measure success?
Checklist
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Does this change update the version of CAPI we're using?
Accessibility test checklist
Tested