Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various SpecialReportAlt bugs #26003

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Fix various SpecialReportAlt bugs #26003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
959d445
Fix hover state on special-report-alt cards for feature article type
ioannakok Mar 21, 2023
af935ad
Fix clock for SpecialReportAlt cards outside palette
ioannakok Mar 21, 2023
b39fd7d
Fix Opinion background for SpecialReportAlt cards outside palette
ioannakok Mar 21, 2023
40b9d49
Fix Interview headline for SpecialReportAlt cards outside palette
ioannakok Mar 21, 2023
512646e
Fix hover state in media and live SpecialReportAlt cards
ioannakok Mar 23, 2023
b47b675
Fix opinion SpecialReportAlt card outside of palette
ioannakok Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions static/src/stylesheets/module/facia-garnett/_item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,14 @@ $block-height: 58px;
color: #ffffff;
}

.fc-item--pillar-special-report-alt {
.fc-item__meta {
.inline-icon {
fill: $special-report-alt-dark;
Copy link
Contributor Author

@ioannakok ioannakok Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVGs in meta (like the clock and the comment bubble) outside the palette

Before After
image image
image image

}
}
}

.fc-item__meta {
@include fs-textSans(1);
color: $brightness-46;
Expand Down
2 changes: 1 addition & 1 deletion static/src/stylesheets/module/facia-garnett/_pillars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ $pillars: (
background-color: $special-report-alt-faded;

.fc-item__container.u-faux-block-link--hover {
background-color: darken($special-report-alt-faded, 2%);
background-color: darken($special-report-alt-pastel, 5%);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover state of feature

Before After
image image
image image


.fc-item__timestamp,
.fc-trail__count--commentcount {
Expand Down
25 changes: 24 additions & 1 deletion static/src/stylesheets/module/facia-garnett/item-types/_fc-item--type-comment.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,35 @@
// if pillar news we override news pallete with opinion palette for comment cards
&.fc-item--pillar-news {
@include colours(map-get($pillars, opinion));

&.fc-item--pillar-special-report-alt {
background-color: $special-report-alt-faded;

.fc-item__timestamp,
.fc-trail__count--commentcount {
background-color: $special-report-alt-faded;
}

.fc-item__meta {
color: $special-report-alt-dark;
}

.fc-item__container.u-faux-block-link--hover {
background-color: darken($special-report-alt-pastel, 5%);

.fc-item__timestamp,
.fc-trail__count--commentcount {
background-color: darken($special-report-alt-pastel, 5%);

Copy link
Contributor Author

@ioannakok ioannakok Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type comment with pillar news and special-report-alt (non-hover & hover)

Before After
image image
image image

}
}
}
}
}

.fc-item--pillar-special-report-alt {
.fc-item__container > .fc-item__meta {
@include multiline(3, rgba(60, 60, 60, .3));
@include multiline(3, rgba(112, 112, 112, .3));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the grey lines for opinion cards to be the same grey as all the lines / borders in the palette


display: flex;
position: absolute;
Expand Down
1 change: 1 addition & 0 deletions static/src/stylesheets/module/facia-garnett/item-types/_fc-item--type-interview.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@
@include overide-interview-headline-colours(arts, $culture-dark, $culture-pastel);
@include overide-interview-headline-colours(lifestyle, $lifestyle-dark, $news-pastel);
@include overide-interview-headline-colours(special-report, #ffffff, #ffffff);
@include overide-interview-headline-colours(special-report-alt, $special-report-alt-dark, $special-report-alt-dark);
Copy link
Contributor Author

@ioannakok ioannakok Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
image image

8 changes: 1 addition & 7 deletions static/src/stylesheets/module/facia-garnett/item-types/_fc-item--type-liveblog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,7 @@
// darken on hover
.u-faux-block-link--hover {
@if $pillar == special-report-alt {
background-color: darken($color1, 2%);
} @else {
background-color: darken($color1, 5%);
}

@if $pillar == special-report-alt {
background-color: darken($color1, 2%);
background-color: darken($special-report-alt-pastel, 5%);
Copy link
Contributor Author

@ioannakok ioannakok Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
image image

} @else {
background-color: darken($color1, 5%);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate code

}
Expand Down
2 changes: 1 addition & 1 deletion static/src/stylesheets/module/facia-garnett/item-types/_fc-item--type-media.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@

&:hover,
.u-faux-block-link--hover {
background-color: darken($special-report-alt-faded, 2%);
background-color: darken($special-report-alt-pastel, 5%);
Copy link
Contributor Author

@ioannakok ioannakok Mar 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
image image

}

.fc-sublink__link {
Expand Down