-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various SpecialReportAlt bugs #26003
Changes from all commits
959d445
af935ad
b39fd7d
40b9d49
512646e
b47b675
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -415,7 +415,7 @@ $pillars: ( | |
background-color: $special-report-alt-faded; | ||
|
||
.fc-item__container.u-faux-block-link--hover { | ||
background-color: darken($special-report-alt-faded, 2%); | ||
background-color: darken($special-report-alt-pastel, 5%); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
.fc-item__timestamp, | ||
.fc-trail__count--commentcount { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -282,12 +282,35 @@ | |
// if pillar news we override news pallete with opinion palette for comment cards | ||
&.fc-item--pillar-news { | ||
@include colours(map-get($pillars, opinion)); | ||
|
||
&.fc-item--pillar-special-report-alt { | ||
background-color: $special-report-alt-faded; | ||
|
||
.fc-item__timestamp, | ||
.fc-trail__count--commentcount { | ||
background-color: $special-report-alt-faded; | ||
} | ||
|
||
.fc-item__meta { | ||
color: $special-report-alt-dark; | ||
} | ||
|
||
.fc-item__container.u-faux-block-link--hover { | ||
background-color: darken($special-report-alt-pastel, 5%); | ||
|
||
.fc-item__timestamp, | ||
.fc-trail__count--commentcount { | ||
background-color: darken($special-report-alt-pastel, 5%); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
} | ||
} | ||
} | ||
} | ||
|
||
.fc-item--pillar-special-report-alt { | ||
.fc-item__container > .fc-item__meta { | ||
@include multiline(3, rgba(60, 60, 60, .3)); | ||
@include multiline(3, rgba(112, 112, 112, .3)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixes the grey lines for opinion cards to be the same grey as all the lines / borders in the palette |
||
|
||
display: flex; | ||
position: absolute; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,4 @@ | |
@include overide-interview-headline-colours(arts, $culture-dark, $culture-pastel); | ||
@include overide-interview-headline-colours(lifestyle, $lifestyle-dark, $news-pastel); | ||
@include overide-interview-headline-colours(special-report, #ffffff, #ffffff); | ||
@include overide-interview-headline-colours(special-report-alt, $special-report-alt-dark, $special-report-alt-dark); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,13 +61,7 @@ | |
// darken on hover | ||
.u-faux-block-link--hover { | ||
@if $pillar == special-report-alt { | ||
background-color: darken($color1, 2%); | ||
} @else { | ||
background-color: darken($color1, 5%); | ||
} | ||
|
||
@if $pillar == special-report-alt { | ||
background-color: darken($color1, 2%); | ||
background-color: darken($special-report-alt-pastel, 5%); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} @else { | ||
background-color: darken($color1, 5%); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate code |
||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,7 +121,7 @@ | |
|
||
&:hover, | ||
.u-faux-block-link--hover { | ||
background-color: darken($special-report-alt-faded, 2%); | ||
background-color: darken($special-report-alt-pastel, 5%); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
.fc-sublink__link { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVGs in meta (like the clock and the comment bubble) outside the palette