-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cards styles for SpecialReportAlt #6314
Conversation
Size Change: +108 B (0%) Total Size: 1.67 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
Will accept the chromatic diffs after #6313 gets merged as there are duplicates |
These look good to me! @ioannakok @DanielCliftonGuardian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM
49e382e
to
0fe2dcf
Compare
Also fixing straightlines colour for SpecialreportAlt Comment and Opinion cards
e54e16a
to
9481266
Compare
Co-authored-by: Daniel Clifton daniel.clifton@guardian.co.uk
What does this change?
Why?
To match the designs
Screenshots
Carousel
Standard
With media type
With quotes
Live