Fix clock in SpecialReportAlt card #25992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the card is inside a container with a palette, we want the palette colours to be applied. !important in the css applied to the card was not allowing this to happen.
To match designs
…for special-report-alt
ioannakok
force-pushed
the
ioanna/fix-cardstyle-for-special-report-alt
branch
from
c0d7dd4
to
dfcb697
Compare
Base automatically changed from
ioanna/fix-cardstyle-for-special-report-alt
to
main
March 21, 2023 10:14
ioannakok
commented
Mar 21, 2023
| </span> | ||
| </time> | ||
| } else { | ||
| <time class="fc-item__timestamp@if(timeStampDisplay.javaScriptUpdate) { js-item__timestamp}" |
There was a problem hiding this comment.
How to do else here?
|
Fixed with this: #25984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Index fronts show a clock and time of publication. This PR fixes those for
SpecialReportAltin order to match the designs.Does this change need to be reproduced in dotcom-rendering ?
Screenshots
Other pillars stay the same
What is the value of this and can you measure success?
Checklist
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Does this change update the version of CAPI we're using?
Accessibility test checklist
Tested