Add SpecialReportAlt card styles
#25693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
ioannakok
force-pushed
the
ioanna/frontend-should-understand-cardstyle-specialreportalt
branch
2 times, most recently
from
6d12779
to
6fc0b4f
Compare
Base automatically changed from
ioanna/frontend-should-understand-cardstyle-specialreportalt
to
main
November 21, 2022 11:36
ioannakok
force-pushed
the
ioanna/add-special-report-card-colours
branch
from
1adaec8
to
ed54cb9
Compare
ioannakok
changed the title
ioannakok
changed the title
SpecialReportAlt card styles
ioannakok
commented
Nov 21, 2022
| } | ||
| } | ||
|
|
||
| background-color: $special-report-alt-faded !important; |
There was a problem hiding this comment.
Regarding the abundant use of !important in this PR please see discussion here
HarryFischer
approved these changes
Nov 21, 2022
|
Seen on PROD (merged by @ioannakok 18 minutes and 25 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds SpecialReportAlt card styles. These styles will be applied when a container has no palette and the cards are of type SpecialReportAlt.
Re-introduces changes of this PR which was reverted by this.
Does this change need to be reproduced in dotcom-rendering ?
Add cards styles for SpecialReportAlt dotcom-rendering#6314
Screenshots
Standard type
Comment type
With media type
What is the value of this and can you measure success?
Checklist
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Does this change update the version of CAPI we're using?
Accessibility test checklist
Tested