Update Logo styling for advertising partner #11217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +280 B (+0.04%) Total Size: 794 kB
ℹ️ View Unchanged
|
deedeeh
force-pushed
the
dina/update-logo-styling-for-advertising-partner
branch
from
d42f6c0
to
a34121f
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
deedeeh
force-pushed
the
dina/update-logo-styling-for-advertising-partner
branch
from
ecfc9e6
to
2728a29
Compare
Jakeii
reviewed
May 16, 2024
mxdvl
reviewed
May 17, 2024
There was a problem hiding this comment.
Looking good, I have left a handful of small thoughts and questions about some of the CSS declarations which you might want to address, but no blockers.
It seems pretty clear from this approach that the use of a context provider for Config is more ergonomic than prop drilling. This is something the @guardian/dotcom-platform should ensure is as smooth and performant as possible in the future: #8795
Thanks for your review Max! I used the prop drilling approach with Section Front and TagPages but the Config one with Articles as this is how it seemed easier to do it that way. |
mxdvl
approved these changes
May 21, 2024
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
deedeeh
force-pushed
the
dina/update-logo-styling-for-advertising-partner
branch
from
3f234bb
to
1157aaa
Compare
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR updates logo styling for
sponsoredwith the new labelsAdvertising partnerandExclusive advertising partnerwhich was requested by US.The change will be in Articles, Interactives, Section Front and Tag Pages. It will also be for Web and App. In this PR Articles and Interactives are supported by DCAR but not Fronts so there will be a separate ticket for Section Front and Tag Pages for App.
Here is a list of useful PRs related to the new labels:
Here is the Figma file for the design.
@Amouzle and I had a couple of meetings with the US team regarding the design and based on DCR codebase and Source foundations we agreed on the following:
dotcom-rendering/dotcom-rendering/src/palette.ts
Line 1856 in 7bf3652
There has been changes in DCR for Label styling based on design so I removed the new label colour for light and dark mode and kept what we already have in main.
dotcom-rendering/dotcom-rendering/src/palette.ts
Line 1845 in 7bf3652
The Figma file doesn't have the previous changes but I thought to include it in the PR.
In order to test this I changed the label to
supported byso when you are reviewing the PR you can replace the value to be one of the existing labels. The screenshots will also havesupported byjust to show the before and after when the new labels are live. Screenshots were taken in different times and sizes that is why they Before and After columns don't have the same width.A 0% AB test has been added because the new labels aren't live yet so once they are anyone can opt in to check the new design for the
Advertising partnerandExclusive advertising partner. Check guardian/frontend#27136.This is an opportunity to make any changes or improvements in design before we roll it out.
Why?
To enhance the branding of Guardian Labs (US) content by making logos more prominent. This design was created to improve the advertising experience, helping to secure additional budget from advertisers.
Additionally, this change will more clearly indicate that the content is funded by advertisers.
Screenshots