Add support for sponsorship packages #26926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly to get access to new commercial-shared sponsored tag wording
fredex42
approved these changes
Feb 28, 2024
|
Thank you for this @davidfurey! This really helped out me and @frederickobrien as we needed to test a new version of the CAPI client on #26931, which due to the breaking changes of v20 and v21 would have been much more work if we hadn't been able to rebase from this branch 🎉 |
prout-bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @davidfurey 12 minutes and 14 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @davidfurey 13 minutes and 18 seconds ago)
|
|
Just for information here is the upstream commercial-shared PR guardian/commercial-shared#59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Allows US advertising team to sell sponsorships with "Advertising partner" and "Exclusive advertising partner" wording. See guardian/tagmanager#508 for more information.
This mainly involves library bumps, but since the CAPI library hasn't been bumped since the recipe atom was deprecated and the recipe element created, there are unfortunately a couple of commits to tidy that up that are unrelated to my main goal. See guardian/content-atom#161