-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Storybook to the updated logo styling for "Advertising partner" #11603
Conversation
Size Change: -1.12 kB (-0.13%) Total Size: 842 kB
ℹ️ View Unchanged
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great run locally with storybook, new story components added and styled 👍
What does this change?
This is a follow up work to add new stories for some of the existed UI components in Storybook for the work #11217 and #11485
The stories that has been added are in
ArticleMeta.apps
,ArticleMeta
andFrontSection
as we wanted to test the updated logo design forAdvertising partner
andExclusive advertising partner
labels in articles, Section Front and TagPages.Why?
This will give us confidence if anyone made UI changes to the logo updates code there will be major UI differences when we add the
run_chromatic
label and that will alert the developer to check their code.Screenshots
Articles - Web
Articles - Apps
Section Front
Tag Front