-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set live updated logo styling for Advertising Partner #11485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +5 B (0%) Total Size: 816 kB ℹ️ View Unchanged
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
1 task
mxdvl
approved these changes
May 28, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
May 30, 2024
arelra
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this @deedeeh ! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR sets live the updated logo styling for
Advertising Partner
andExclusive advertising partner
labels by replacing the 0% test with a switch. Here is the related PR guardian/frontend#27184This change will only by applied to the two labels in articles and interactives. The changes will appear in TagPages if the user is in the
variant
which is 20% for the testDCRTagPages
. There were still discussions to increase this percentage to 100% and a decision was made on 30th of May so now everyone should be able to see the change in Tag Front.For more details check #11217
I contacted CP to set a logo with one of these labels live to be able to test in CODE and all are working as expected.
Why?
The US team requested to set it live.
Screenshots
The following screenshots are DCR rendered: