pubsub: refactor (fixes #98). #107

stephenplusplus · 2014-08-12T05:05:55Z

Here's the PubSub API refactor (#98)! The readme updates + tests (regression & unit) will be good places to see it in action. Let me know if you see anything you think can be improved!

Note: this could likely still use a few more tests, and definitely needs a sweep for doc block accuracy. I'll get to these soon.

lib/pubsub/index.js

+    };
+  }
+  options = options || {};
+  options.name = options.name.replace(/.*\//, '');


rakyll · 2014-08-12T20:21:59Z

Added some comments, also applicable to Topic get/create/initialize.

stephenplusplus · 2014-08-12T21:02:32Z

Will get right to it 👍

stephenplusplus · 2014-08-12T23:35:51Z

Made the updates!

stephenplusplus · 2014-08-12T23:36:12Z

Oops, not to the readme. I'll get to that next.

lib/common/util.js

+  }
+}
+
+module.exports.LazyCreate = LazyCreate;


lib/pubsub/subscription.js

+      this.exists_ = true;
+      this.delete(this.create.bind(this));
+      return;
+    }


rakyll · 2014-08-13T17:08:16Z

This PR is getting too big to review, can we first work on Subscription only?

stephenplusplus · 2014-08-13T17:28:19Z

This PR is getting too big to review, can we first work on Subscription only?

Sure, I can start over. It sounds like we're keeping consistent with the old API, as far as behavior, with some name changes: listSubscriptions -> getSubscriptions, getSubscription -> subscribe and such. Hopefully that will ease the complexity this PR brought on. Speaking of this PR, I'll close it since "fixes #98" won't be an accurate association.

…107)

…107) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/a8ab5675-1982-4cf5-b9b7-36794038b975/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@8cf6d28

…andwritten libraries (#107) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9

* feat: KMS configuration in settings chore: formatting changes PiperOrigin-RevId: 430243637 Source-Link: googleapis/googleapis@95da686 Source-Link: googleapis/googleapis-gen@a1f056b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYTFmMDU2Yjc2ODljY2JlNWFlYmMwYmZkZDMxOGU5OTQ1ZWU3NjAyYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 2.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 470911839 Source-Link: googleapis/googleapis@3527566 Source-Link: googleapis/googleapis-gen@f16a1d2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjE2YTFkMjI0ZjAwYTYzMGVhNDNkNmE5YTFhMzFmNTY2ZjQ1Y2RlYSJ9 feat: accept google-gax instance as a parameter Please see the documentation of the client constructor for details. PiperOrigin-RevId: 470332808 Source-Link: googleapis/googleapis@d4a2367 Source-Link: googleapis/googleapis-gen@e97a1ac Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTk3YTFhYzIwNGVhZDRmZTczNDFmOTFlNzJkYjdjNmFjNjAxNjM0MSJ9

samples: pull in latest typeless bot, clean up some comments Source-Link: https://togithub.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e

* test: use fully qualified request type name in tests PiperOrigin-RevId: 475685359 Source-Link: googleapis/googleapis@7a12973 Source-Link: googleapis/googleapis-gen@370c729 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^13.0.0` -> `^14.0.0`](https://renovatebot.com/diffs/npm/sinon/13.0.2/14.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/compatibility-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/14.0.0/confidence-slim/13.0.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v14.0.0`](https://togithub.com/sinonjs/sinon/blob/HEAD/CHANGES.md#1400) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v13.0.2...v14.0.0) - [`c2bbd826`](https://togithub.com/sinonjs/sinon/commit/c2bbd82641444eb5b32822489ae40f185afbbf00) Drop node 12 (Morgan Roderick) > And embrace Node 18 > > See https://nodejs.org/en/about/releases/ *Released by Morgan Roderick on 2022-05-07.* </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-org-policy).

* chore(deps): upgrade gapic-generator-java to 2.4.1 PiperOrigin-RevId: 422607515 Source-Link: googleapis/googleapis@ba2ffd6 Source-Link: googleapis/googleapis-gen@73ba4ad Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzNiYTRhZGQyMzlhNjE5ZGE1NjdmZmJkNGU1NzMwZmRkNmRlMDRkMyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [1.3.4](https://www.github.com/googleapis/nodejs-bigquery-connection/compare/v1.3.3...v1.3.4) (2021-07-01) ### Bug Fixes * **deps:** require google-gax v2.17.0 ([#104](https://www.github.com/googleapis/nodejs-bigquery-connection/issues/104)) ([a03eb4b](https://www.github.com/googleapis/nodejs-bigquery-connection/commit/a03eb4b9be4dac6e3cfc7d2ceb169dcff80617ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

pubsub: refactor (fixes googleapis#98).

7c1fc2f

rakyll reviewed Aug 12, 2014
View reviewed changes

lib/pubsub/index.js

};

}

options = options || {};

options.name = options.name.replace(/.*\//, '');

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed Aug 12, 2014
View reviewed changes

lib/common/util.js

}

}

module.exports.LazyCreate = LazyCreate;

This comment was marked as spam.

Sign in to view

added LazyCreate util method.

f2ae0c4

stephenplusplus reviewed Aug 12, 2014
View reviewed changes

stephenplusplus closed this Aug 13, 2014

stephenplusplus mentioned this pull request Aug 13, 2014

pubsub: API refactor #98

Closed

stephenplusplus mentioned this pull request Mar 18, 2015

Automatically create topic / subscription if not found. #445

Closed

chingor13 pushed a commit that referenced this pull request Aug 22, 2022

build: use linkinator for docs test (#107)

48ce788

sofisl mentioned this pull request Sep 15, 2022

migrate code from googleapis/nodejs-redis #3360

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Sep 15, 2022

chore: update nyc and eslint configs (#107)

9e81cf2

sofisl mentioned this pull request Sep 16, 2022

migrate code from googleapis/nodejs-os-login #3366

Closed

4 tasks

sofisl pushed a commit that referenced this pull request Sep 16, 2022

chore(deps): update dependency @google-cloud/nodejs-repo-tools to v3 (#…

c77c75f

…107)

sofisl pushed a commit that referenced this pull request Oct 5, 2022

chore(deps): update dependency @google-cloud/nodejs-repo-tools to v3 (#…

373b539

…107)

This was referenced Oct 5, 2022

migrate code from googleapis/nodejs-os-login #3388

Closed

migrate code from googleapis/nodejs-os-login #3389

Closed

sofisl pushed a commit that referenced this pull request Oct 8, 2022

chore(deps): update dependency @google-cloud/nodejs-repo-tools to v3 (#…

30b3f06

…107)

This was referenced Oct 11, 2022

migrate code from googleapis/nodejs-os-login #3391

Merged

migrate code from googleapis/nodejs-language #3395

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-access-approval #3605

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Nov 11, 2022

test(nodejs): remove 15 add 16 (#1322) (#107)

7de37be

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-service-management #3608

Merged

migrate code from googleapis/nodejs-service-control #3609

Merged

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-service-usage #3610

Merged

migrate code from googleapis/nodejs-dms #3611

Merged

sofisl mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-cloud-tpu #3612

Merged

4 tasks

This was referenced Nov 11, 2022

migrate code from googleapis/nodejs-org-policy #3614

Merged

migrate code from googleapis/nodejs-essential-contacts #3615

Merged

migrate code from googleapis/nodejs-private-catalog #3616

Merged

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-network-connectivity #3643

Merged

4 tasks

sofisl mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-bigquery-connection #3646

Merged

4 tasks

sofisl mentioned this pull request Jan 10, 2023

migrate code from googleapis/nodejs-dlp #3837

Merged

4 tasks

sofisl pushed a commit that referenced this pull request Jan 10, 2023

chore: do not use npm ci (#107)

2dc1c50

sofisl pushed a commit that referenced this pull request Jan 24, 2023

chore(deps): lock file maintenance (#107)

d2db212

sofisl pushed a commit that referenced this pull request Jan 25, 2023

chore(deps): lock file maintenance (#107)

5250c12

sofisl pushed a commit that referenced this pull request Sep 14, 2023

fix(deps): update dependency @google-cloud/common to ^0.25.0 (#107)

cc7e623

sofisl mentioned this pull request Sep 14, 2023

migrate code from googleapis/nodejs-dns #4657

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pubsub: refactor (fixes #98). #107

pubsub: refactor (fixes #98). #107

stephenplusplus commented Aug 12, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 12, 2014

stephenplusplus commented Aug 12, 2014

stephenplusplus commented Aug 12, 2014

stephenplusplus commented Aug 12, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 13, 2014

stephenplusplus commented Aug 13, 2014

pubsub: refactor (fixes #98). #107

pubsub: refactor (fixes #98). #107

Conversation

stephenplusplus commented Aug 12, 2014

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 12, 2014

stephenplusplus commented Aug 12, 2014

stephenplusplus commented Aug 12, 2014

stephenplusplus commented Aug 12, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

rakyll commented Aug 13, 2014

stephenplusplus commented Aug 13, 2014