Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore: Avoid clearing offset when start cursor is set #93

Merged
merged 2 commits into from
Aug 5, 2014

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Aug 5, 2014

  • Clearing offset for next page's query only.
  • Making pagination sample less confusing.

@rakyll
Copy link
Contributor Author

rakyll commented Aug 5, 2014

Fixes #79 and #80.

@rakyll
Copy link
Contributor Author

rakyll commented Aug 5, 2014

Merging since it's trivial.

rakyll pushed a commit that referenced this pull request Aug 5, 2014
datastore: Avoid clearing offset when start cursor is set
@rakyll rakyll merged commit c1e37e1 into googleapis:master Aug 5, 2014
chingor13 pushed a commit that referenced this pull request Sep 12, 2022
Committer: @parthea
PiperOrigin-RevId: 404756337
Source-Link: googleapis/googleapis@f034e5f
Source-Link: googleapis/googleapis-gen@8bb2d07
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGJiMmQwNzM1YTg2MWYyY2ZhZDRiOTA3MWYxY2FkNzQwNjVmNzY5NiJ9
chingor13 pushed a commit that referenced this pull request Sep 14, 2022
Committer: @parthea
PiperOrigin-RevId: 404756337
Source-Link: googleapis/googleapis@f034e5f
Source-Link: googleapis/googleapis-gen@8bb2d07
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGJiMmQwNzM1YTg2MWYyY2ZhZDRiOTA3MWYxY2FkNzQwNjVmNzY5NiJ9
sofisl pushed a commit that referenced this pull request Sep 15, 2022
sofisl pushed a commit that referenced this pull request Sep 27, 2022
sofisl pushed a commit that referenced this pull request Oct 11, 2022
* chore: ignore package-log.json

* remove locky

* renovateeee
sofisl pushed a commit that referenced this pull request Oct 12, 2022
sofisl pushed a commit that referenced this pull request Oct 12, 2022
sofisl pushed a commit that referenced this pull request Oct 13, 2022
Source-Author: Stephen <stephenplusplus@users.noreply.github.com>
Source-Date: Wed Jun 17 14:16:18 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: b10590a4a1568548dd13cfcea9aa11d40898144b
Source-Link: googleapis/synthtool@b10590a

Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
sofisl pushed a commit that referenced this pull request Oct 13, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ts-loader](https://togithub.com/TypeStrong/ts-loader) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/ts-loader/7.0.5/8.0.0) |

---

### Release Notes

<details>
<summary>TypeStrong/ts-loader</summary>

### [`v8.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v800)

[Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v7.0.5...v8.0.0)

-   [Support for symlinks in project references](https://togithub.com/TypeStrong/ts-loader/pull/1136) - thanks [@&#8203;sheetalkamat](https://togithub.com/sheetalkamat)!
-   `ts-loader` now supports TypeScript 3.6 and greater **BREAKING CHANGE**

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-recommender).
sofisl pushed a commit that referenced this pull request Oct 13, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsdoc-region-tag](https://togithub.com/googleapis/jsdoc-region-tag) | [`^1.0.6` -> `^2.0.0`](https://renovatebot.com/diffs/npm/jsdoc-region-tag/1.0.6/2.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/compatibility-slim/1.0.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/confidence-slim/1.0.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/jsdoc-region-tag</summary>

### [`v2.0.0`](https://togithub.com/googleapis/jsdoc-region-tag/blob/HEAD/CHANGELOG.md#&#8203;200-httpsgithubcomgoogleapisjsdoc-region-tagcomparev131v200-2022-05-20)

[Compare Source](https://togithub.com/googleapis/jsdoc-region-tag/compare/v1.3.1...v2.0.0)

##### ⚠ BREAKING CHANGES

-   update library to use Node 12 ([#&#8203;107](https://togithub.com/googleapis/jsdoc-region-tag/issues/107))

##### Build System

-   update library to use Node 12 ([#&#8203;107](https://togithub.com/googleapis/jsdoc-region-tag/issues/107)) ([5b51796](https://togithub.com/googleapis/jsdoc-region-tag/commit/5b51796771984cf8b978990025f14faa03c19923))

##### [1.3.1](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.3.0...v1.3.1) (2021-08-11)

##### Bug Fixes

-   **build:** migrate to using main branch ([#&#8203;79](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/79)) ([5050615](https://www.github.com/googleapis/jsdoc-region-tag/commit/50506150b7758592df5e389c6a5c3d82b3b20881))

### [`v1.3.1`](https://togithub.com/googleapis/jsdoc-region-tag/blob/HEAD/CHANGELOG.md#&#8203;131-httpswwwgithubcomgoogleapisjsdoc-region-tagcomparev130v131-2021-08-11)

[Compare Source](https://togithub.com/googleapis/jsdoc-region-tag/compare/v1.3.0...v1.3.1)

### [`v1.3.0`](https://togithub.com/googleapis/jsdoc-region-tag/blob/HEAD/CHANGELOG.md#&#8203;130-httpswwwgithubcomgoogleapisjsdoc-region-tagcomparev120v130-2021-07-08)

[Compare Source](https://togithub.com/googleapis/jsdoc-region-tag/compare/v1.2.0...v1.3.0)

##### Features

-   classdesc can also contain link ([#&#8203;74](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/74)) ([e57b3ad](https://www.github.com/googleapis/jsdoc-region-tag/commit/e57b3add05abf0c427c4044d507ca600ef58c102))

### [`v1.2.0`](https://togithub.com/googleapis/jsdoc-region-tag/blob/HEAD/CHANGELOG.md#&#8203;120-httpswwwgithubcomgoogleapisjsdoc-region-tagcomparev110v120-2021-07-07)

[Compare Source](https://togithub.com/googleapis/jsdoc-region-tag/compare/v1.1.0...v1.2.0)

##### Features

-   replace relative URL with cloud.google.com ([#&#8203;72](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/72)) ([212febc](https://www.github.com/googleapis/jsdoc-region-tag/commit/212febc933c246a5e31675e128ad65c45d300cac))

### [`v1.1.0`](https://togithub.com/googleapis/jsdoc-region-tag/blob/HEAD/CHANGELOG.md#&#8203;110-httpswwwgithubcomgoogleapisjsdoc-region-tagcomparev106v110-2021-06-10)

[Compare Source](https://togithub.com/googleapis/jsdoc-region-tag/compare/v1.0.6...v1.1.0)

##### Features

-   add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#&#8203;56](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/56)) ([9e3649a](https://www.github.com/googleapis/jsdoc-region-tag/commit/9e3649a3c1778f65115993048d8eca80e5958df8))

##### [1.0.6](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.0.5...v1.0.6) (2020-09-02)

##### Bug Fixes

-   main was pointing to old location ([#&#8203;33](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/33)) ([46be7f8](https://www.github.com/googleapis/jsdoc-region-tag/commit/46be7f83d75506529e46fef4e1bfd5d585b2bc5c))

##### [1.0.5](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.0.4...v1.0.5) (2020-08-29)

##### Bug Fixes

-   move system and samples test from Node 10 to Node 12 ([#&#8203;30](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/30)) ([0cfc38b](https://www.github.com/googleapis/jsdoc-region-tag/commit/0cfc38b339c130389a0eb6927e4a8dd4db5c39e2))

##### [1.0.4](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.0.3...v1.0.4) (2020-01-09)

##### Bug Fixes

-   tag issue of undefined ([#&#8203;11](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/11)) ([adf52c5](https://www.github.com/googleapis/jsdoc-region-tag/commit/adf52c5dc7f8531fc951f9cf80283d17c3dead37))

##### [1.0.3](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.0.2...v1.0.3) (2019-11-21)

##### Bug Fixes

-   node_modules can have folders with .js extension ([#&#8203;3](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/3)) ([dccba19](https://www.github.com/googleapis/jsdoc-region-tag/commit/dccba19cf52290f84a559b19f4691e109fb7f031))

##### [1.0.2](https://www.github.com/bcoe/jsdoc-region-tag/compare/v1.0.1...v1.0.2) (2019-11-12)

##### Bug Fixes

-   **deps:** remove unused yargs dep ([#&#8203;5](https://www.togithub.com/bcoe/jsdoc-region-tag/issues/5)) ([1f87fbb](https://www.github.com/bcoe/jsdoc-region-tag/commit/1f87fbb70103a9589c8740db7bbd12f2989169bf))

##### [1.0.1](https://www.github.com/bcoe/jsdoc-region-tag/compare/v1.0.0...v1.0.1) (2019-11-11)

##### Bug Fixes

-   **license:** license to Google ([#&#8203;3](https://www.togithub.com/bcoe/jsdoc-region-tag/issues/3)) ([7f7ff0f](https://www.github.com/bcoe/jsdoc-region-tag/commit/7f7ff0f550f35af2cbcd1cc4e7ccb852de2ff01e))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-cloud-shell).
sofisl pushed a commit that referenced this pull request Oct 13, 2022
* chore: ignore package-log.json

* remove locky

* renovateeee
sofisl pushed a commit that referenced this pull request Oct 13, 2022
sofisl pushed a commit that referenced this pull request Nov 9, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
🤖 I have created a release *beep* *boop*
---


## [2.2.0](https://togithub.com/googleapis/nodejs-cloud-tpu/compare/v2.1.0...v2.2.0) (2022-11-10)


### Features

* Add Secure Boot support to TPU v2alpha1 API ([#98](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/98)) ([e4fc278](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/e4fc27883278b8161bb7ad598dd83021e2467d99))


### Bug Fixes

* Allow passing gax instance to client constructor ([#96](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/96)) ([d636ecf](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/d636ecf4798258a71f289bd6a6add2cf45e6a2cb))
* Better support for fallback mode ([#91](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/91)) ([a291abd](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/a291abd4a0418eb375f9c4a27f19735afee4acca))
* Change import long to require ([#92](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/92)) ([5de09bb](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/5de09bb8786a790ff5a6d643f8493b6f6ea3c4ec))
* **deps:** Use google-gax v3.5.2 ([#104](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/104)) ([86b8617](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/86b86173fe7f8dd33e5cb6abb683f32d148670c6))
* Do not import the whole google-gax from proto JS ([#1553](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/1553)) ([#95](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/95)) ([e4289c1](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/e4289c164ea2123947328ceddfb09cf083e50a19))
* Preserve default values in x-goog-request-params header ([#97](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/97)) ([42310b7](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/42310b7a99b51320e9924f8ecd1d75513b28b598))
* Regenerated protos JS and TS definitions ([#107](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/107)) ([7e3cba5](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/7e3cba5fd489373a7c460369d37f04c32e3cd9c3))
* Remove pip install statements ([#1546](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/1546)) ([#94](https://togithub.com/googleapis/nodejs-cloud-tpu/issues/94)) ([7a26fe6](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/7a26fe63b51c661bdd22bfafecc3d4291247dddf))
* use google-gax v3.3.0 ([e4289c1](https://togithub.com/googleapis/nodejs-cloud-tpu/commit/e4289c164ea2123947328ceddfb09cf083e50a19))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Nov 11, 2022
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 12, 2022
* feat: new APIs added to reflect updates to the filestore service

- Add ENTERPRISE Tier
- Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot
- Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare
- Add ConnectMode to NetworkConfig (for Private Service Access support)
- New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING)
- Add SuspensionReason (for KMS related suspension)
- Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled

PiperOrigin-RevId: 487492758

Source-Link: googleapis/googleapis@5be5981

Source-Link: googleapis/googleapis-gen@ab0e217
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 12, 2022
🤖 I have created a release *beep* *boop*
---


## [2.2.0](https://togithub.com/googleapis/nodejs-filestore/compare/v2.1.0...v2.2.0) (2022-11-11)


### Features

* New APIs added to reflect updates to the filestore service ([#93](https://togithub.com/googleapis/nodejs-filestore/issues/93)) ([619e7f1](https://togithub.com/googleapis/nodejs-filestore/commit/619e7f142a621303afc58b38261711d33584ea5f))


### Bug Fixes

* Allow passing gax instance to client constructor ([#82](https://togithub.com/googleapis/nodejs-filestore/issues/82)) ([37a928b](https://togithub.com/googleapis/nodejs-filestore/commit/37a928bf3c049d0cd66e4efa5d41717fa5ff9a28))
* Better support for fallback mode ([#77](https://togithub.com/googleapis/nodejs-filestore/issues/77)) ([c339f3f](https://togithub.com/googleapis/nodejs-filestore/commit/c339f3f49c0a10fd2d42a64de20a9d2f06ae061e))
* Change import long to require ([#78](https://togithub.com/googleapis/nodejs-filestore/issues/78)) ([c9ce9d1](https://togithub.com/googleapis/nodejs-filestore/commit/c9ce9d147dd1cc6f99b63e53af9cf75c1999dc90))
* **deps:** Use google-gax v3.5.2 ([#89](https://togithub.com/googleapis/nodejs-filestore/issues/89)) ([5fde972](https://togithub.com/googleapis/nodejs-filestore/commit/5fde972b08be1106b42bce644f1282f690b93677))
* Do not import the whole google-gax from proto JS ([#1553](https://togithub.com/googleapis/nodejs-filestore/issues/1553)) ([#81](https://togithub.com/googleapis/nodejs-filestore/issues/81)) ([e0b4ac4](https://togithub.com/googleapis/nodejs-filestore/commit/e0b4ac42145ad648f3ae5f6c77917a2dd94d5192))
* Preserve default values in x-goog-request-params header ([#83](https://togithub.com/googleapis/nodejs-filestore/issues/83)) ([2cd3cb0](https://togithub.com/googleapis/nodejs-filestore/commit/2cd3cb022d1cb11fa3d04dbda58fd32de995c462))
* Regenerated protos JS and TS definitions ([#92](https://togithub.com/googleapis/nodejs-filestore/issues/92)) ([cb324b9](https://togithub.com/googleapis/nodejs-filestore/commit/cb324b9f3f93eaea7228386e5bf406ed570bafcc))
* Remove pip install statements ([#1546](https://togithub.com/googleapis/nodejs-filestore/issues/1546)) ([#80](https://togithub.com/googleapis/nodejs-filestore/issues/80)) ([73de8d6](https://togithub.com/googleapis/nodejs-filestore/commit/73de8d63b8b221df09c193400d1028cf3924a6ae))
* use google-gax v3.3.0 ([e0b4ac4](https://togithub.com/googleapis/nodejs-filestore/commit/e0b4ac42145ad648f3ae5f6c77917a2dd94d5192))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Nov 18, 2022
sofisl pushed a commit that referenced this pull request Jan 24, 2023
sofisl pushed a commit that referenced this pull request Jan 25, 2023
sofisl pushed a commit that referenced this pull request Jan 26, 2023
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^9.2.1` -> `^10.0.0`](https://renovatebot.com/diffs/npm/sinon/9.2.4/10.0.0) | [![age](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/compatibility-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/10.0.0/confidence-slim/9.2.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v10.0.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#&#8203;1000--2021-03-22)

[Compare Source](https://togithub.com/sinonjs/sinon/compare/v9.2.4...v10.0.0)

==================

-   Upgrade nise to 4.1.0
-   Use [@&#8203;sinonjs/eslint-config](https://togithub.com/sinonjs/eslint-config)[@&#8203;4](https://togithub.com/4) => Adopts ES2017 => Drops support for IE 11, Legacy Edge and legacy Safari

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-ai-platform).
sofisl pushed a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant