-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: run lint & tests. #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is great! |
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
This was referenced Oct 5, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
This was referenced Oct 12, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/452e1583-6c83-495a-ad97-fb34fc6f653f/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@3a00b7f
This was referenced Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* feat: Update Logging API with latest changes PiperOrigin-RevId: 429289471 Source-Link: googleapis/googleapis@acd5f89 Source-Link: googleapis/googleapis-gen@8a12622 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGExMjYyMjUzNmFlMmU5YTg5NzgxOThhMTUxZTg5MjM0YjgzOWIyMCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.4](https://togithub.com/googleapis/nodejs-private-catalog/compare/v2.0.3...v2.0.4) (2022-11-11) ### Bug Fixes * **deps:** Use google-gax v3.5.2 ([#111](https://togithub.com/googleapis/nodejs-private-catalog/issues/111)) ([8a0d368](https://togithub.com/googleapis/nodejs-private-catalog/commit/8a0d368277802a788989c270ad400117010c0855)) * Preserve default values in x-goog-request-params header ([#104](https://togithub.com/googleapis/nodejs-private-catalog/issues/104)) ([4259f2f](https://togithub.com/googleapis/nodejs-private-catalog/commit/4259f2f26191b70e98cab9b2a75bef793ce3d7da)) * Regenerated protos JS and TS definitions ([#114](https://togithub.com/googleapis/nodejs-private-catalog/issues/114)) ([ffce6dc](https://togithub.com/googleapis/nodejs-private-catalog/commit/ffce6dc1534a49c2ae7354f32c28d03b90cd69d7)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.2](https://togithub.com/googleapis/nodejs-essential-contacts/compare/v2.0.1...v2.0.2) (2022-11-11) ### Bug Fixes * Allow passing gax instance to client constructor ([#110](https://togithub.com/googleapis/nodejs-essential-contacts/issues/110)) ([fb3d596](https://togithub.com/googleapis/nodejs-essential-contacts/commit/fb3d596a8dee0ab338485a862955757cfbcd99c2)) * Better support for fallback mode ([#105](https://togithub.com/googleapis/nodejs-essential-contacts/issues/105)) ([c23259b](https://togithub.com/googleapis/nodejs-essential-contacts/commit/c23259b0a493e5bcdabf408902ffe16be76e7cb0)) * Change import long to require ([#106](https://togithub.com/googleapis/nodejs-essential-contacts/issues/106)) ([f009752](https://togithub.com/googleapis/nodejs-essential-contacts/commit/f009752ac7a8267ef6444fa9eb7338e70e6687d6)) * **deps:** Use google-gax v3.5.2 ([#117](https://togithub.com/googleapis/nodejs-essential-contacts/issues/117)) ([f90a6e7](https://togithub.com/googleapis/nodejs-essential-contacts/commit/f90a6e75af5c23754bf67bea1b8fd55c96a1330f)) * Do not import the whole google-gax from proto JS ([#1553](https://togithub.com/googleapis/nodejs-essential-contacts/issues/1553)) ([#109](https://togithub.com/googleapis/nodejs-essential-contacts/issues/109)) ([c7e8827](https://togithub.com/googleapis/nodejs-essential-contacts/commit/c7e8827859caa1c23bc38f43ca71cfe8d6784dfd)) * Preserve default values in x-goog-request-params header ([#111](https://togithub.com/googleapis/nodejs-essential-contacts/issues/111)) ([5074ba2](https://togithub.com/googleapis/nodejs-essential-contacts/commit/5074ba241d3e5ac5dc4a47ef7fc9cc3761f406cb)) * Regenerated protos JS and TS definitions ([#120](https://togithub.com/googleapis/nodejs-essential-contacts/issues/120)) ([4989df1](https://togithub.com/googleapis/nodejs-essential-contacts/commit/4989df17b1c7d0deb7907f7659b0fd2032833e8f)) * Remove pip install statements ([#1546](https://togithub.com/googleapis/nodejs-essential-contacts/issues/1546)) ([#108](https://togithub.com/googleapis/nodejs-essential-contacts/issues/108)) ([9fb4d1c](https://togithub.com/googleapis/nodejs-essential-contacts/commit/9fb4d1c253480086fe101cef0817874b313d076a)) * use google-gax v3.3.0 ([c7e8827](https://togithub.com/googleapis/nodejs-essential-contacts/commit/c7e8827859caa1c23bc38f43ca71cfe8d6784dfd)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
#105) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 421098407 Source-Link: googleapis/googleapis@a635f71 Source-Link: googleapis/googleapis-gen@56c652b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTZjNjUyYjc4YmJlYTBhODExOWMzNDk4NTIyYjcxN2JmOWRiZTliZSJ9
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
This was referenced Nov 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 18, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
* chore: ignore package-log.json * remove locky * renovateeee
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
4 tasks
4 tasks
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis won't run the linter for us, as it defaults to running
npm test
(which doesn't include the lint script). This should make it work, although I've never overwritten Travis's default behavior before.Another option would be to have
npm test
include the lint, and rename the currenttest
to a less generic "spec" or "unit" or something along those lines.