-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage write streams should be able to use a pre-existing uri #1322
Conversation
@@ -1528,7 +1528,7 @@ File.prototype.startResumableUpload_ = function(dup, options) { | |||
metadata: {} | |||
}, options); | |||
|
|||
var uploadStream = resumableUpload({ | |||
var config = { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Thank you! Could you add a line in the jsdocs for:
Something like: * @param {string} options.uri - The URI for an already-created resumable
* upload. See {module:storage/file#createResumableUpload}. |
Ah yes, good call @stephenplusplus. Updated! |
Coveralls is going crazy again. Sorry I missed this the first time, could you add a test to check that the uri option is passed through to gcs-resumable-upload? |
Also, just released gcs-resumable-upload@0.6.0 with URI support -- can you upgrade the package.json to use this new one? |
👍 on it @stephenplusplus |
Source-Link: googleapis/synthtool@6981da4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:3563b6b264989c4f5aa31a3682e4df36c95756cfef275d3201508947cbfc511e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@6981da4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:3563b6b264989c4f5aa31a3682e4df36c95756cfef275d3201508947cbfc511e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@6981da4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:3563b6b264989c4f5aa31a3682e4df36c95756cfef275d3201508947cbfc511e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@6981da4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:3563b6b264989c4f5aa31a3682e4df36c95756cfef275d3201508947cbfc511e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@6981da4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:3563b6b264989c4f5aa31a3682e4df36c95756cfef275d3201508947cbfc511e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@6981da4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:3563b6b264989c4f5aa31a3682e4df36c95756cfef275d3201508947cbfc511e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Allow users to pass through an already existing uri when creating a write stream.
Closes #1321