Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: type check input. fixes #500 #501

Merged
merged 2 commits into from
Apr 15, 2015
Merged

pubsub: type check input. fixes #500 #501

merged 2 commits into from
Apr 15, 2015

Conversation

stephenplusplus
Copy link
Contributor

Fixes #500

This confirms every message provided to Topic#publish has a data property.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2015
@stephenplusplus stephenplusplus added the api: pubsub Issues related to the Pub/Sub API. label Apr 14, 2015
tmatsuo
tmatsuo reviewed Apr 14, 2015
View reviewed changes
lib/pubsub/topic.js
@@ -178,6 +179,12 @@ Topic.prototype.publish = function(messages, callback) {
throw new Error('Cannot publish without a message.');
}

messages.forEach(function(message) {
if (!util.is(message, 'object')) {

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus force-pushed the spp--pubsub-publish-error-message branch from 8277608 to eef7ce2 Compare April 15, 2015 14:19
@ryanseys
Copy link
Contributor

LGTM.

ryanseys added a commit that referenced this pull request Apr 15, 2015
@ryanseys
Merge pull request #501 from stephenplusplus/spp--pubsub-publish-erro…
64b6140 
…r-message

pubsub: type check input. fixes #500
@ryanseys ryanseys merged commit 64b6140 into googleapis:master Apr 15, 2015
@sofisl sofisl mentioned this pull request Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 15, 2022
@release-please
chore: release 2.2.5 (#501)
9e7b84a 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.2.5](https://www.github.com/googleapis/nodejs-redis/compare/v2.2.4...v2.2.5) (2021-07-21)


### Bug Fixes

* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#500](https://www.github.com/googleapis/nodejs-redis/issues/500)) ([e19ae5a](https://www.github.com/googleapis/nodejs-redis/commit/e19ae5a3371fba34b0a59f769609e64582e00da4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 16, 2022
@gcf-owl-bot
test(nodejs): remove 15 add 16 (#1322) (#501)
fc09a57
sofisl pushed a commit that referenced this pull request Sep 27, 2022
@yoshi-automation
fix(browser): check for fetch on window (#501)
ab61876
@sofisl sofisl mentioned this pull request Sep 27, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@gcf-owl-bot
test(nodejs): remove 15 add 16 (#1322) (#501)
265ab69
@sofisl sofisl mentioned this pull request Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@gcf-owl-bot
test(nodejs): remove 15 add 16 (#1322) (#501)
e0b9e64
@sofisl sofisl mentioned this pull request Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 8, 2022
@gcf-owl-bot
test(nodejs): remove 15 add 16 (#1322) (#501)
bb4bee9
This was referenced Oct 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Oct 11, 2022
@yoshi-automation
build: perform publish using Node 12 (#501)
9033063 
Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Wed Aug 12 12:12:29 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5747555f7620113d9a2078a48f4c047a99d31b3e
Source-Link: googleapis/synthtool@5747555
sofisl pushed a commit that referenced this pull request Oct 13, 2022
@yoshi-automation @sofisl
build: perform publish using Node 12 (#501)
68408c2 
Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Wed Aug 12 12:12:29 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5747555f7620113d9a2078a48f4c047a99d31b3e
Source-Link: googleapis/synthtool@5747555
sofisl pushed a commit that referenced this pull request Nov 9, 2022
@yoshi-automation
fix(browser): check for fetch on window (#501)
8bc3e26
This was referenced Nov 9, 2022
Closed
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@JustinBeckwith
chore: remove duplicate mocha config (#501)
9d60ccd
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
docs(node): support "stable"/"preview" release level (#1312) (#501)
3ce686f
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
fix(browser): check for fetch on window (#501)
f0ee9e1
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore: release 2.1.4 (#502)
8ef567a 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.1.4](https://www.github.com/googleapis/nodejs-monitoring/compare/v2.1.3...v2.1.4) (2020-11-25)


### Bug Fixes

* **browser:** check for fetch on window ([#501](https://www.github.com/googleapis/nodejs-monitoring/issues/501)) ([a923606](https://www.github.com/googleapis/nodejs-monitoring/commit/a9236060fdd4516e5f3fa31a5bf76895ad8bf6c1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please @bcoe
chore: release 1.1.1 (#501)
52fdafd
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
docs(samples): add auto-generated Node samples (#501)
bdecd11 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 398604509

Source-Link: googleapis/googleapis@6ef16b9

Source-Link: googleapis/googleapis-gen@8314e1e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODMxNGUxZWFkM2U5MDZkYmYyMDEyY2VkOGQ5MmYyYmM4ZGQ0NWM5NSJ9
sofisl pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore: release 2.2.0 (#501)
b3fb11c 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This was referenced Nov 17, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 18, 2022
@gcf-owl-bot
chore: remove unused proto imports (#501)
6909d68 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468735472

Source-Link: googleapis/googleapis@cfa1b37

Source-Link: googleapis/googleapis-gen@09b7666
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9

feat: Adding uris to indicator of compromise (IOC) field
PiperOrigin-RevId: 468598080

Source-Link: googleapis/googleapis@07c3f50

Source-Link: googleapis/googleapis-gen@dd0b32a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGQwYjMyYTE4OWE5YjE1YTc5NDYwMmVlNWY3YzdjNDg2MDBmNmU0YSJ9
@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl added a commit that referenced this pull request Jan 10, 2023
@renovate-bot @sofisl
chore(deps): update dependency ts-loader to v8 (#501)
4e3cfb1 
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
@sofisl sofisl mentioned this pull request Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 13, 2023
@alexander-fenster
fix(deps): require google-gax v2.12.0 (#501)
6ce6e55
sofisl pushed a commit that referenced this pull request Sep 13, 2023
@release-please
chore: release 2.4.2 (#502)
9273842 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.4.2](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.1...v2.4.2) (2021-05-12)


### Bug Fixes

* **deps:** require google-gax v2.12.0 ([#501](https://www.github.com/googleapis/nodejs-automl/issues/501)) ([f88cc91](https://www.github.com/googleapis/nodejs-automl/commit/f88cc915df6ac67f7dc46fa345d9fc481b12d7da))
* use require() to load JSON protos ([#504](https://www.github.com/googleapis/nodejs-automl/issues/504)) ([4cd9585](https://www.github.com/googleapis/nodejs-automl/commit/4cd9585da11b3a9189ed8f3f0e5ddc76c578a462))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub: unhelpful error message when trying to publish a string.
4 participants
@stephenplusplus @ryanseys @tmatsuo @googlebot