Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: type check input. fixes #500 #501

Merged

Conversation

stephenplusplus
Copy link
Contributor

Fixes #500

This confirms every message provided to Topic#publish has a data property.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 14, 2015
@stephenplusplus stephenplusplus added the api: pubsub Issues related to the Pub/Sub API. label Apr 14, 2015
@@ -178,6 +179,12 @@ Topic.prototype.publish = function(messages, callback) {
throw new Error('Cannot publish without a message.');
}

messages.forEach(function(message) {
if (!util.is(message, 'object')) {

This comment was marked as spam.

@stephenplusplus stephenplusplus force-pushed the spp--pubsub-publish-error-message branch from 8277608 to eef7ce2 Compare April 15, 2015 14:19
@ryanseys
Copy link
Contributor

LGTM.

ryanseys added a commit that referenced this pull request Apr 15, 2015
@ryanseys ryanseys merged commit 64b6140 into googleapis:master Apr 15, 2015
sofisl pushed a commit that referenced this pull request Sep 15, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### [2.2.5](https://www.github.com/googleapis/nodejs-redis/compare/v2.2.4...v2.2.5) (2021-07-21)


### Bug Fixes

* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#500](https://www.github.com/googleapis/nodejs-redis/issues/500)) ([e19ae5a](https://www.github.com/googleapis/nodejs-redis/commit/e19ae5a3371fba34b0a59f769609e64582e00da4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Sep 16, 2022
sofisl pushed a commit that referenced this pull request Sep 27, 2022
sofisl pushed a commit that referenced this pull request Oct 5, 2022
sofisl pushed a commit that referenced this pull request Oct 5, 2022
sofisl pushed a commit that referenced this pull request Oct 8, 2022
sofisl pushed a commit that referenced this pull request Oct 11, 2022
Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Wed Aug 12 12:12:29 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5747555f7620113d9a2078a48f4c047a99d31b3e
Source-Link: googleapis/synthtool@5747555
sofisl pushed a commit that referenced this pull request Oct 13, 2022
Source-Author: Benjamin E. Coe <bencoe@google.com>
Source-Date: Wed Aug 12 12:12:29 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5747555f7620113d9a2078a48f4c047a99d31b3e
Source-Link: googleapis/synthtool@5747555
sofisl pushed a commit that referenced this pull request Nov 9, 2022
sofisl pushed a commit that referenced this pull request Nov 10, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 398604509

Source-Link: googleapis/googleapis@6ef16b9

Source-Link: googleapis/googleapis-gen@8314e1e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODMxNGUxZWFkM2U5MDZkYmYyMDEyY2VkOGQ5MmYyYmM4ZGQ0NWM5NSJ9
sofisl pushed a commit that referenced this pull request Nov 17, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 18, 2022
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468735472

Source-Link: googleapis/googleapis@cfa1b37

Source-Link: googleapis/googleapis-gen@09b7666
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDliNzY2NjY1NjUxMGY1YjAwYjg5M2YwMDNhMGJhNTc2NmY5ZTI1MCJ9

feat: Adding uris to indicator of compromise (IOC) field
PiperOrigin-RevId: 468598080

Source-Link: googleapis/googleapis@07c3f50

Source-Link: googleapis/googleapis-gen@dd0b32a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGQwYjMyYTE4OWE5YjE1YTc5NDYwMmVlNWY3YzdjNDg2MDBmNmU0YSJ9
sofisl added a commit that referenced this pull request Jan 10, 2023
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: unhelpful error message when trying to publish a string.
4 participants