Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New x-goog-api-client information for gRPC-based APIs #2019

Closed
15 tasks done
jmuk opened this issue Feb 24, 2017 · 10 comments
Closed
15 tasks done

New x-goog-api-client information for gRPC-based APIs #2019

jmuk opened this issue Feb 24, 2017 · 10 comments
Assignees
Labels
api: logging Issues related to the Cloud Logging API. api: monitoring Issues related to the Cloud Monitoring API. api: pubsub Issues related to the Pub/Sub API. api: spanner Issues related to the Spanner API. priority: p0 Highest priority. Critical issue. P0 implies highest priority.

Comments

@jmuk
Copy link
Contributor

jmuk commented Feb 24, 2017

(sorry not filed an issue so far); we are going to add x-goog-api-client header info to the gRPC-based APIs in certain format:

  • common-grpc based: "gl-node/(node version) gccl/(library version) grpc/(grpc version)"
  • APIs on top of gapic: "gl-node/(node version) gccl/(library version) gapic/(autogen version) gax/(gax version) grpc/(grpc version)"

Also the gapic autogen files will generate its own http header -- so that if the user chooses to use gapic layer directly, it has the information, but not with gccl part. This means we need to regenerate the autogen files too.

This issue tracks its progress.

The following APIs will be affected:

@jmuk jmuk self-assigned this Feb 24, 2017
@jmuk
Copy link
Contributor Author

jmuk commented Feb 24, 2017

cc: @bjwatson @omaray @danoscarmike

jmuk added a commit to jmuk/gcloud-node that referenced this issue Feb 24, 2017
stephenplusplus pushed a commit that referenced this issue Feb 24, 2017
@stephenplusplus stephenplusplus added api: datastore Issues related to the Datastore API. api: language Issues related to the Cloud Natural Language API API. api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. api: spanner Issues related to the Spanner API. api: speech Issues related to the Speech-to-Text API. api: vision Issues related to the Cloud Vision API. api: bigtable Issues related to the Bigtable API. api: monitoring Issues related to the Cloud Monitoring API. labels Feb 24, 2017
jmuk added a commit to jmuk/gcloud-node that referenced this issue Feb 24, 2017
jmuk added a commit to jmuk/gcloud-node that referenced this issue Feb 24, 2017
stephenplusplus pushed a commit that referenced this issue Feb 24, 2017
stephenplusplus pushed a commit that referenced this issue Feb 24, 2017
@bjwatson
Copy link

Can we track the PRs for each API, the same way as we're doing for Python and Ruby?

@bjwatson bjwatson added priority: p0 Highest priority. Critical issue. P0 implies highest priority. Status: Release Blocking labels Feb 27, 2017
@danoscarmike danoscarmike removed api: datastore Issues related to the Datastore API. api: language Issues related to the Cloud Natural Language API API. api: speech Issues related to the Speech-to-Text API. api: vision Issues related to the Cloud Vision API. api: bigtable Issues related to the Bigtable API. labels Feb 27, 2017
@danoscarmike danoscarmike added Status: Release Blocking priority: p0 Highest priority. Critical issue. P0 implies highest priority. and removed Status: Release Blocking labels Feb 27, 2017
@bjwatson
Copy link

bjwatson commented Mar 1, 2017

@stephenplusplus @jmuk Can we track the PRs for each API, the same way as we're doing for Python and Ruby?

@bjwatson
Copy link

bjwatson commented Mar 1, 2017

@jmuk Please note that this ordering is wrong:

APIs on top of gapic: "gl-node/(node version) gccl/(library version) gax/(gax version) gapic/(autogen version) grpc/(grpc version)"

The gapic/ token should appear before the gax/ token:

APIs on top of gapic: "gl-node/(node version) gccl/(library version) gapic/(autogen version) gax/(gax version) grpc/(grpc version)"

@jmuk
Copy link
Contributor Author

jmuk commented Mar 1, 2017

My bad, it seems the ordering is different from both the expected order and what I wrote here, sigh. I'll make a fix for that.

@bjwatson
Copy link

bjwatson commented Mar 1, 2017

Thanks, Jun.

jmuk added a commit to jmuk/gcloud-node that referenced this issue Mar 7, 2017
jmuk added a commit to jmuk/gcloud-node that referenced this issue Mar 7, 2017
stephenplusplus pushed a commit that referenced this issue Mar 7, 2017
jmuk added a commit to jmuk/gcloud-node that referenced this issue Mar 9, 2017
stephenplusplus pushed a commit that referenced this issue Mar 9, 2017
@jmuk
Copy link
Contributor Author

jmuk commented Mar 9, 2017

Now the code on master has this fully; @stephenplusplus or @callmehiphop -- please push new version of these API clients to npmjs.com, so that further API calls can contain this data.

@bjwatson
Copy link

Thanks @jmuk!

@stephenplusplus and @callmehiphop please let me know when all of the client libs have been republished with these new headers.

@stephenplusplus
Copy link
Contributor

I'll be publishing these tomorrow. It involves a bit more work than expected because of a breaking change in @google-cloud/common-grpc.

@stephenplusplus
Copy link
Contributor

All modules have been published.

sofisl pushed a commit that referenced this issue Oct 11, 2022
sofisl pushed a commit that referenced this issue Oct 13, 2022
sofisl pushed a commit that referenced this issue Nov 11, 2022
sofisl pushed a commit that referenced this issue Jan 17, 2023
sofisl pushed a commit that referenced this issue Jan 24, 2023
sofisl pushed a commit that referenced this issue Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. api: monitoring Issues related to the Cloud Monitoring API. api: pubsub Issues related to the Pub/Sub API. api: spanner Issues related to the Spanner API. priority: p0 Highest priority. Critical issue. P0 implies highest priority.
Projects
None yet
Development

No branches or pull requests

4 participants