-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New x-goog-api-client information for gRPC-based APIs #2019
Comments
@stephenplusplus @jmuk Can we track the PRs for each API, the same way as we're doing for Python and Ruby? |
@jmuk Please note that this ordering is wrong:
The
|
My bad, it seems the ordering is different from both the expected order and what I wrote here, sigh. I'll make a fix for that. |
Thanks, Jun. |
Updates googleapis#2019, and fixes googleapis#2063.
Now the code on master has this fully; @stephenplusplus or @callmehiphop -- please push new version of these API clients to npmjs.com, so that further API calls can contain this data. |
Thanks @jmuk! @stephenplusplus and @callmehiphop please let me know when all of the client libs have been republished with these new headers. |
I'll be publishing these tomorrow. It involves a bit more work than expected because of a breaking change in |
All modules have been published. |
(sorry not filed an issue so far); we are going to add x-goog-api-client header info to the gRPC-based APIs in certain format:
"gl-node/(node version) gccl/(library version) grpc/(grpc version)"
"gl-node/(node version) gccl/(library version) gapic/(autogen version) gax/(gax version) grpc/(grpc version)"
Also the gapic autogen files will generate its own http header -- so that if the user chooses to use gapic layer directly, it has the information, but not with
gccl
part. This means we need to regenerate the autogen files too.This issue tracks its progress.
The following APIs will be affected:
The text was updated successfully, but these errors were encountered: