Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner on master throwing errors from GAX #2063

Closed
stephenplusplus opened this issue Mar 8, 2017 · 3 comments · Fixed by #2066
Closed

Spanner on master throwing errors from GAX #2063

stephenplusplus opened this issue Mar 8, 2017 · 3 comments · Fixed by #2066
Assignees
@stephenplusplus
Labels
api: spanner Issues related to the Spanner API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@stephenplusplus
Copy link
Contributor

@jmuk will you try running the system tests from packages/spanner on master with the latest dependencies? It instantly throws:

  1) Spanner "before all" hook:
     Uncaught TypeError: Cannot read property 'apply' of undefined
      at src\admin\instance\v1\instance_admin_client.js:165:47
      at wrappedCall (node_modules\google-gax\lib\paged_iteration.js:75:12)
      at timeoutFunc (node_modules\google-gax\lib\api_callable.js:171:12)
      at repeat (node_modules\google-gax\lib\api_callable.js:235:19)
      at retryingFunc (node_modules\google-gax\lib\api_callable.js:264:7)
      at _combinedTickCallback (internal/process/next_tick.js:74:11)
      at process._tickCallback (internal/process/next_tick.js:98:9)
@stephenplusplus stephenplusplus added api: spanner Issues related to the Spanner API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. Status: Release Blocking labels Mar 8, 2017
@stephenplusplus stephenplusplus mentioned this issue Mar 8, 2017
Merged
7 tasks
@jmuk jmuk added priority: p0 Highest priority. Critical issue. P0 implies highest priority. Status: Acknowledged labels Mar 9, 2017
jmuk added a commit to jmuk/gcloud-node that referenced this issue Mar 9, 2017
@jmuk
Regenerate spanner API clients.
39322c4 
Updates googleapis#2019, and fixes googleapis#2063.
@jmuk jmuk mentioned this issue Mar 9, 2017
Merged
@jmuk
Copy link
Contributor

jmuk commented Mar 9, 2017

Created #2066. system-test succeeds on my environment with this.

stephenplusplus pushed a commit that referenced this issue Mar 9, 2017
@jmuk @stephenplusplus
Regenerate spanner API clients. (#2066)
1939dea 
Updates #2019, and fixes #2063.
@stephenplusplus
Copy link
Contributor Author

Thanks. So what was the problem?

@jmuk
Copy link
Contributor

jmuk commented Mar 9, 2017

I actually didn't get the exact error you wrote but I see another error. But both errors would indicate that some recent changes on google-gax was incompatible with the code generated previously (we are doing this since we want to keep the major version of google-gax to be 0 for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: spanner Issues related to the Spanner API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Regenerate spanner API clients. jmuk/gcloud-node
2 participants
@stephenplusplus @jmuk