Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates the new x-goog-api-client header. #2020

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

jmuk
Copy link
Contributor

@jmuk jmuk commented Feb 24, 2017

This will send x-goog-api-client with the following format:
gl-node/(node version) gccl/(library version) grpc/(grpc version)

We will use this information for future tracking.

The GAPIC autogen files will have a slightly different format,
and that will be addressed later. This PR only changes the
APIs using gRPC without the GAPIC.

Updates #2019

This will send x-goog-api-client with the following format:
gl-node/(node version) gccl/(library version) grpc/(grpc version)

We will use this information for future tracking.

The GAPIC autogen files will have a slightly different format,
and that will be addressed later. This PR only changes the
APIs using gRPC without the GAPIC.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2017
@stephenplusplus stephenplusplus merged commit 8d0a6ad into googleapis:master Feb 24, 2017
@stephenplusplus
Copy link
Contributor

@jmuk - sorry, can you PR this again? Each gRPC API using GrpcService already passes in its package.json. The GrpcService class has access to it under options.packageJson.

jmuk added a commit to jmuk/gcloud-node that referenced this pull request Mar 30, 2017
This introduces this header for non-gapic APIs.
Revise of googleapis#2020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants