Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce x-goog-api-client for common-grpc #2164

Merged
merged 3 commits into from
Mar 30, 2017
Merged

Reintroduce x-goog-api-client for common-grpc #2164

merged 3 commits into from
Mar 30, 2017

Conversation

jmuk
Copy link
Contributor

@jmuk jmuk commented Mar 30, 2017

This introduces this header for non-gapic APIs.
Revise of #2020.

@jmuk
Reintroduce x-goog-api-client for common-grpc
ed92594 
This introduces this header for non-gapic APIs.
Revise of googleapis#2020.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2017
@jmuk jmuk mentioned this pull request Mar 30, 2017
Merged
stephenplusplus
stephenplusplus suggested changes Mar 30, 2017
View reviewed changes
packages/common-grpc/src/service.js Outdated
@@ -178,6 +179,11 @@ function GrpcService(config, options) {

this.grpcMetadata = new grpc.Metadata();

this.grpcMetadata.add('x-goog-api-client', [
'gl-node/' + process.versions.node,
'gccl/' + (config.packageJson.version || ''),

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/common-grpc/src/service.js Outdated
'gl-node/' + process.versions.node,
'gccl/' + (config.packageJson.version || ''),
'grpc/' + grpcVersion
].join(' '));
if (config.grpcMetadata) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/common-grpc/test/service.js Outdated
'x-goog-api-client': [
'gl-node/' + process.versions.node,
'gccl/' + CONFIG.packageJson.version,
'grpc/' + grpcVersion].join(' ')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/common-grpc/src/service.js Outdated
this.grpcMetadata.add('x-goog-api-client', [
'gl-node/' + process.versions.node,
'gccl/' + (config.packageJson.version || ''),
'grpc/' + grpcVersion

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/common-grpc/test/service.js Outdated
@@ -21,6 +21,7 @@ var duplexify = require('duplexify');
var extend = require('extend');
var googleProtoFiles = require('google-proto-files');
var grpc = require('grpc');
var grpcVersion = require('grpc/package.json').version;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage increased (+3.0e-06%) to 99.987% when pulling ed92594 on jmuk:header into f7d4b05 on GoogleCloudPlatform:master.

@jmuk
Fixes
8e043e7 
- remove grpcVersion from src/service.js
- style fixes
@jmuk
Refactor test/service.js
c6dda85
@coveralls
Copy link

Coverage Status

Coverage increased (+2.0e-06%) to 99.987% when pulling c6dda85 on jmuk:header into f7d4b05 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 4c71ccd into googleapis:master Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmuk @coveralls @stephenplusplus @googlebot