Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAX headers #3049

Closed
6 of 7 tasks
lukesneeringer opened this issue Feb 22, 2017 · 10 comments
Closed
6 of 7 tasks

GAX headers #3049

lukesneeringer opened this issue Feb 22, 2017 · 10 comments
Assignees
Labels
api: clouderrorreporting Issues related to the Error Reporting API. api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. api: spanner Issues related to the Spanner API. api: speech Issues related to the Speech-to-Text API. api: vision Issues related to the Cloud Vision API.

Comments

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Feb 22, 2017

This is a tracking meta-issue for adding the gccl header to the GAX side of each API client library:

Each PR should:

  • Add the lib_name and lib_version keyword arguments to the GAPIC client.
  • Bump the version of the client library to 0.23.0
  • Bump the GAPIC dependency to 0.15.0

Completion List:

@bjwatson
Copy link

@lukesneeringer Logging and Datastore are most urgent to complete, since they're Beta already.

@dhermes What's the status of #2746? If we don't have the manual layer ported onto GAPIC, we're going to have to implement the full custom header (x-goog-api-client) in the manual layer.

@tseaver
Copy link
Contributor

tseaver commented Feb 22, 2017

Datastore is still not GAPIC (although we've added the dependency).

$ git grep gapic datastore/
datastore/setup.py:    'gapic-google-cloud-datastore-v1 >= 0.14.0, < 0.15dev',

@tseaver
Copy link
Contributor

tseaver commented Feb 22, 2017

@lukesneeringer has pubsub in work. I will tackle logging and error_reporting bits today.

Reprioritized: leaving this on to @lukesneeringer / @dhermes .

@dhermes
Copy link
Contributor

dhermes commented Feb 23, 2017

#2746 was my next priority after this issue. Since @lukesneeringer is taking the GAPIC ones to the finish line I can work on that now?

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Feb 23, 2017

Yeah.

Edit: Although I will probably want help getting the umbrella release across the finish line, which I assert can and should precede #2746 (datastore can be 0.23.1).

@bjwatson
Copy link

Thanks @dhermes!

@lukesneeringer
Copy link
Contributor Author

lukesneeringer commented Feb 23, 2017

@lukesneeringer Logging and Datastore are most urgent to complete, since they're Beta already.

@omaray told us the exact opposite on Datastore; that it was least urgent because it is not being tracked yet. Based on that, I was actually intending to let it wait until @dhermes did #2746.

@bjwatson
Copy link

Ok, I would go with what @omaray said. :)

@lukesneeringer
Copy link
Contributor Author

All items complete except Datastore. Closing this issue and tracking Datastore separately.

@bjwatson
Copy link

Thanks @lukesneeringer, @dhermes, and @tseaver! Can you let me know when packages are published with these updates? I assume that will be sometime today, due to the RTD issues.

@dhermes dhermes added api: clouderrorreporting Issues related to the Error Reporting API. api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. api: spanner Issues related to the Spanner API. api: speech Issues related to the Speech-to-Text API. api: vision Issues related to the Cloud Vision API. labels Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the Error Reporting API. api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. api: spanner Issues related to the Spanner API. api: speech Issues related to the Speech-to-Text API. api: vision Issues related to the Cloud Vision API.
Projects
None yet
Development

No branches or pull requests

4 participants