-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAX headers #3049
Comments
@lukesneeringer Logging and Datastore are most urgent to complete, since they're Beta already. @dhermes What's the status of #2746? If we don't have the manual layer ported onto GAPIC, we're going to have to implement the full custom header ( |
Datastore is still not GAPIC (although we've added the dependency). $ git grep gapic datastore/
datastore/setup.py: 'gapic-google-cloud-datastore-v1 >= 0.14.0, < 0.15dev', |
Reprioritized: leaving this on to @lukesneeringer / @dhermes . |
#2746 was my next priority after this issue. Since @lukesneeringer is taking the GAPIC ones to the finish line I can work on that now? |
Yeah. Edit: Although I will probably want help getting the umbrella release across the finish line, which I assert can and should precede #2746 (datastore can be 0.23.1). |
Thanks @dhermes! |
@omaray told us the exact opposite on Datastore; that it was least urgent because it is not being tracked yet. Based on that, I was actually intending to let it wait until @dhermes did #2746. |
Ok, I would go with what @omaray said. :) |
All items complete except Datastore. Closing this issue and tracking Datastore separately. |
Thanks @lukesneeringer, @dhermes, and @tseaver! Can you let me know when packages are published with these updates? I assume that will be sometime today, due to the RTD issues. |
This is a tracking meta-issue for adding the
gccl
header to the GAX side of each API client library:Each PR should:
lib_name
andlib_version
keyword arguments to the GAPIC client.Completion List:
Datastore(Putting this off.)The text was updated successfully, but these errors were encountered: