Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install target #140

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Add install target #140

merged 1 commit into from
Feb 7, 2019

Conversation

carolynvs
Copy link
Member

The install target dumps the bin into ~/.porter and symlinks it to /usr/local/bin.

Note that this doesn't work with porter until #139 is merged.

The install target dumps the bin into ~/.porter and symlinks it
to /usr/local/bin.
@carolynvs carolynvs requested a review from vdice February 5, 2019 20:10
@ghost ghost assigned carolynvs Feb 5, 2019
@ghost ghost added the review label Feb 5, 2019
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #134 , shall we also install mixins to $(HOME)/.porter?

Also, thoughts on bubbling up actual install location ($(HOME)/.porter) as a top-level/re-usable $PORTER_HOME variable?

@carolynvs
Copy link
Member Author

carolynvs commented Feb 5, 2019

The install target runs build first, which is handling getting all of the mixins into bin before we dump the entire thing over to ~/.porter.

Here's what's in ~/.porter after I deleted my bin, and ~/.porter and then ran make install:

/Users/carolynvs/.porter
├── mixins
│   ├── azure
│   │   ├── azure
│   │   └── azure-runtime
│   ├── exec
│   │   ├── exec
│   │   └── exec-runtime
│   ├── helm
│   │   ├── helm
│   │   └── helm-runtime
│   └── porter
│       ├── porter
│       └── porter-runtime
├── porter
└── templates
    ├── porter.yaml
    └── run

Do you see anything missing?

Yeah, I originally expected that PORTER_HOME at the top of the Makefile would point to ~/.porter, then realized that it doesn't due to the CI tests. 😀 I will follow-up in another PR to change that so that it works like the other Makefiles (and still runs the CI tests from inside bin instead of against the system) #141.

@vdice
Copy link
Member

vdice commented Feb 5, 2019

Ah, now I gotcha 👍. Thank you for the detailed explanation.

@carolynvs carolynvs merged commit 05c04ad into getporter:master Feb 7, 2019
@carolynvs carolynvs deleted the install-target branch February 7, 2019 00:21
@ghost ghost removed the review label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants