Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Makefile/mixin.mk): add install target #134

Closed
wants to merge 1 commit into from

Conversation

vdice
Copy link
Member

@vdice vdice commented Feb 1, 2019

No description provided.

@ghost ghost assigned vdice Feb 1, 2019
@ghost ghost added the review label Feb 1, 2019
@carolynvs
Copy link
Member

Oh shoot! I didn't see this when I submitted #140... 🤦‍♀️

I think that there are some key things from both that we may want to consider smooshing together, but I'm not 100% sure. The most important thing is that porter can figure out on its own where its home directory is, without PORTER_HOME being explicitly set.

The way I did that with my 2 PRs is to symlink, and then make sure porter knew how to follow the symlink back.

How does yours work?

@vdice
Copy link
Member Author

vdice commented Feb 5, 2019

Oooh, I do like the symlink approach; we should go that route. My approach was not as nice (simply copied porter cli bin to /usr/local/bin, only moved mixin/runtime bins to ~/.porter/$PORTER_HOME.

Plus, you've updated documentation! 😅

I'd say, if we add mixin/runtime installation (to ~/.porter/$PORTER_HOME) in #140, we'll be golden. I'll close this one in favor of that route.

@vdice vdice closed this Feb 5, 2019
@ghost ghost removed the review label Feb 5, 2019
@vdice vdice deleted the feat/add-install-target branch February 5, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants