Resolve PORTER_HOME when it's symlinked #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When someone symlinks /usr/local/bin/porter from ~/.porter/porter, we need to handle that properly so that we can still find the mixins and other assests in the original directory. Cache the resolved PORTER_HOME
ghost
assigned
Merged
radu-matei
reviewed
Feb 5, 2019
There was a problem hiding this comment.
There are a bunch of other tests failing on Windows, but one introduced by this PR:
--- FAIL: TestConfig_GetHomeDirFromSymlink (0.17s)
logger.go:11: Resolved porter binary from /usr/local/bin/porter to /root/.porter/porter
config_test.go:38:
Error Trace: config_test.go:38
Error: Not equal:
expected: "/root/.porter"
actual : "\\root\\.porter"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-/root/.porter
+\root\.porter
Test: TestConfig_GetHomeDirFromSymlink
|
@radu-matei Thank you for trying this out on Windows! If you know how to setup an agent on Azure Devops for Windows, we'd appreciate help getting that setup, or a pointer to how you did it for duffle (or some other project). Fixing now. |
|
Fixing now = setting up a windows dev VM so gimme a few hours 😀 |
|
OK got a different makefile setup to catch these problems. I'll fix this test that I broke and then fix the test and add the new CI setup in another PR so we don't break it again. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone symlinks /usr/local/bin/porter from ~/.porter/porter, we need to handle that properly
so that we can still find the mixins and other assets in the original directory.
Also cache the resolved PORTER_HOME so we don't have to do that more than once.