refactor: GL entries build logic for Advance in Separate Party Account option.
#38393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with `Advance as Liability`, partial reconciliation should not post duplicate ledger entries for same reference
make_advance_gl_entries -> add_advance_gl_entries -> add_advance_gl_for_reference 'make_advance_gl_entries' - main method thats builds and post GL entries for all or one specific reference based on parameters 'add_advance_gl_entries' - build GL map for all or one specific reference. Return an array of dict. 'add_advance_gl_for_reference' - utility function to build gl entries. returns dict.
This was referenced Nov 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38393 +/- ##
===========================================
- Coverage 67.23% 60.15% -7.08%
===========================================
Files 758 760 +2
Lines 60619 69470 +8851
===========================================
+ Hits 40756 41791 +1035
- Misses 19863 27679 +7816
|
ruthra-kumar
added a commit
that referenced
this pull request
Dec 1, 2023
…-38393 refactor: GL entries build logic for `Advance in Separate Party Account` option. (backport #38393)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues: #35609
Refactor on how Ledger entries are built for Advance that are booked in separate party account.
Fixes partial payment ledger entries upon unreconciling the invoice from advance payment.
ToDo: