refactor: Advance Payment(Liability) ledger entries and deduplication #37172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
force-pushed
the
advance_as_liability_bug_on_partial_allocation
branch
2 times, most recently
from
c717817
to
3721cb4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #37172 +/- ##
===========================================
- Coverage 67.23% 66.71% -0.53%
===========================================
Files 758 794 +36
Lines 60619 62481 +1862
===========================================
+ Hits 40756 41682 +926
- Misses 19863 20799 +936
|
ruthra-kumar
force-pushed
the
advance_as_liability_bug_on_partial_allocation
branch
2 times, most recently
from
854248d
to
bc74ce3
Compare
ruthra-kumar
changed the title
ruthra-kumar
force-pushed
the
advance_as_liability_bug_on_partial_allocation
branch
from
bc74ce3
to
8deae85
Compare
ruthra-kumar
force-pushed
the
advance_as_liability_bug_on_partial_allocation
branch
2 times, most recently
from
a5f6f40
to
a00ba91
Compare
ruthra-kumar
force-pushed
the
advance_as_liability_bug_on_partial_allocation
branch
from
a00ba91
to
dc6f537
Compare
with `Advance as Liability`, partial reconciliation should not post duplicate ledger entries for same reference
ruthra-kumar
force-pushed
the
advance_as_liability_bug_on_partial_allocation
branch
from
dc6f537
to
3a01d1b
Compare
ruthra-kumar
force-pushed
the
advance_as_liability_bug_on_partial_allocation
branch
from
3a01d1b
to
9221e35
Compare
|
@ruthra-kumar can you check and finish this? |
|
Recent changes to payment_entry.py file made merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues: #35609
Refactor on how Ledger entries are built for
Advancethat are booked in separate party account.