fix: consolidate GL entries based on voucher

[rtdany10]

Create a payment entry without any references. Reconcile the same against multiple invoices using payment reconciliation tool.

Create another payment entry, this time allocate the amounts in the payment entry itself.

Look at the General Ledger:

Even though both payment entry records look the same, they differ in the General Ledger, while the first one has only 2 entries, the second one has n-number of entries(n being the number of unique references).

This PR consolidates it based on voucher and account, if the group_by is Group by Voucher (Consolidated)

General Ledger after this PR:

Also removes debit and credit being on the same line.

[codecov]

Codecov Report

Merging #38337 (b73b7c6) into develop (f258ab5) will decrease coverage by 0.03%.
Report is 28 commits behind head on develop.
The diff coverage is 70.83%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38337      +/-   ##
===========================================
- Coverage    67.27%   67.24%   -0.03%     
===========================================
  Files          757      758       +1     
  Lines        60540    60623      +83     
===========================================
+ Hits         40727    40767      +40     
- Misses       19813    19856      +43     

Files	Coverage Δ
erpnext/buying/doctype/supplier/supplier.py	68.57% <0.00%> (-1.34%)	⬇️
...t/accounts/report/general_ledger/general_ledger.py	70.60% <80.95%> (+0.60%)	⬆️

... and 13 files with indirect coverage changes

[rtdany10]

@deepeshgarg007 @ruthra-kumar

[ruthra-kumar]

@rtdany10

This happens when Book Advance Payments in Separate Party Account is enabled. GL entries are valid, but there is too much splitting on reconciliation that it becomes hard to reason the GL entries.

Rather than fixing it at the report level, I've already made a PR to tidy up the build logic for GL entries.

There are some test cases, that needs to be addressed. Post which I'll merge it. You can test it out let me know if you find anything breaking.

[ruthra-kumar]

closing the pr.

[ruthra-kumar]

Latest PR: #38393