Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Record Advance Payment as a liability #35609

Conversation

GursheenK
Copy link
Member

@GursheenK GursheenK commented Jun 8, 2023

The current flow allows the user to record -

  • Advance Payments Received from Customers as a Negative Asset in the General Ledger
  • Advance Payments Paid to Suppliers as a Negative Liability in the General Ledger

The Book Advance Payments in Separate Party Account feature introduces the option to use separate accounts for recording these Advance Payments. The option can be selected from the Company Doctype > Advance Payments Section

When selected, the user needs to provide the Default Advances Received Account and the Default Advances Paid Account in the Company master.


Screenshot 2023-11-13 at 4 10 57 PM


Default Advance Accounts can be set for a Customer/Customer Group/Supplier/ Supplier Group with respect to multiple companies from the Accounting Tab > Default Accounts Table


Screenshot 2023-11-13 at 4 14 32 PM

Note : If they are not set in the Customer or Supplier Doctypes, then the Default Advance Account mentioned in the Company Master will be used for recording the Advance Payments of that particular party.

Example

A Payment Entry for receiving ₹1000 from a customer is submitted. The General Ledger Entries created for the same will use the Liability Account instead of the Receivable Account since it is an Advance Payment.

Screenshot 2023-11-13 at 4 16 47 PM

Suppose a Sales Invoice with a total of ₹500 is created for the same customer and the Advance Payments are fetched and allocated using the Get Advances Received button. In such a case, when the Sales Invoice is submitted, the General Ledger for the Payment Entry will reflect the following changes.


Screenshot 2023-11-13 at 4 19 54 PM

Since the total allocated amount to the Sales Invoice is ₹500, the same has been debited from the Liability Account. The Liability Account will then hold the remaining ₹500 as an Advance Payment.


no-docs

Issue #34282

Ability to let user record advance payments as liability instead of a negative asset.

Issue frappe#34282
Add Sales and Purchase Invoice Tests to check if GL entries and Outstanding Amount are generated correctly when advance entries are recorded as liability.

Few changes to return value of added column in Payment Entry References.
@GursheenK GursheenK force-pushed the #34282-Record-advance-payment-as-a-liability branch from e380d74 to 5e9821d Compare June 12, 2023 13:00
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #35609 (fda2d2b) into develop (fa3ab67) will increase coverage by 0.05%.
The diff coverage is 91.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35609      +/-   ##
===========================================
+ Coverage    64.15%   64.20%   +0.05%     
===========================================
  Files          785      785              
  Lines        60485    60613     +128     
===========================================
+ Hits         38803    38918     +115     
- Misses       21682    21695      +13     
Impacted Files Coverage Δ
...e/payment_reconciliation/payment_reconciliation.py 93.38% <75.00%> (-0.67%) ⬇️
...xt/accounts/doctype/payment_entry/payment_entry.py 83.37% <86.15%> (+0.05%) ⬆️
erpnext/accounts/utils.py 75.56% <93.75%> (+0.20%) ⬆️
erpnext/accounts/party.py 78.10% <95.00%> (+1.09%) ⬆️
erpnext/controllers/accounts_controller.py 85.58% <96.66%> (+0.32%) ⬆️
erpnext/accounts/general_ledger.py 94.26% <100.00%> (+0.02%) ⬆️

@deepeshgarg007 deepeshgarg007 merged commit 3df0c5e into frappe:develop Jul 1, 2023
11 of 12 checks passed
finesoftke pushed a commit to finesoftke/erpnext that referenced this pull request Aug 5, 2023
…vance-payment-as-a-liability

feat: Record Advance Payment as a liability
@rtdany10
Copy link
Contributor

rtdany10 commented Aug 8, 2023

@deepeshgarg007 will this be backported?
Just saw the label, but any possibility?

ruthra-kumar added a commit that referenced this pull request Nov 22, 2023
fix: partial cancel of gle and ple (backport #35609)
frappe-pr-bot pushed a commit that referenced this pull request Nov 24, 2023
# [14.50.0](v14.49.0...v14.50.0) (2023-11-24)

### Bug Fixes

* don't depreciate non-depreciable assets on scrapping [v14] ([#38294](#38294)) ([5261aba](5261aba))
* partial cancel of gle and ple (backport [#35609](#35609)) ([80bc235](80bc235))
* patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38263](#38263)) ([756f08b](756f08b))
* Supplier `Primary Contact` (backport [#38268](#38268)) ([#38285](#38285)) ([f170cb9](f170cb9))

### Features

* add Bank Transaction to connections in Journal and Payment Entry ([#38297](#38297)) ([06c6da5](06c6da5))

### Performance Improvements

* optimize total_purchase_cost update ([a88d322](a88d322))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants