IGNORE - Native Animation Completion #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
force-pushed
the
nativeanim_rough
branch
from
9757857
to
685f012
Compare
Summary:See discussion here facebook#5796 (comment) **Test plan (required)** Change the babel-preset-react-native dependency to `"babel-preset-react-native": "file:./babel-preset",` so it uses the local babel-preset instead of the one from npm. ``` ./packager/packager.sh --reset-cache ``` open `http://localhost:8081/Examples/UIExplorer/UIExplorerApp.android.bundle?platform=android&dev=true&hot=false&minify=false` and there should not be any added 'strict mode'. Closes facebook#6686 Reviewed By: mkonicek Differential Revision: D3103122 Pulled By: bestander fb-gh-sync-id: 85658ee01bb73f13dacb2b6a48ab121324c13118 fbshipit-source-id: 85658ee01bb73f13dacb2b6a48ab121324c13118
Summary:The goal is to minimize the number of files we need to bootstrap. This allows us to make the upgrade process smoother for everyone. If someone needs to customize the file, we already provide some config options. The ability to copy the file and modify it is always there for those few who need it. **Test plan** Generate a new project with the updated template. The app should build and run fine both in debug and production mode. Related facebook#6292 Closes facebook#6610 Differential Revision: D3109099 Pulled By: foghina fb-gh-sync-id: 13fc89e60daed30bf6349e532a140c1b6f8f053a fbshipit-source-id: 13fc89e60daed30bf6349e532a140c1b6f8f053a
Summary:Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: (You can skip this if you're fixing a typo or adding an app to the Showcase.) Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). Closes facebook#6706 Differential Revision: D3109403 fb-gh-sync-id: 4c92b4dc7950377f9efad6129a49c594bcd9a68a fbshipit-source-id: 4c92b4dc7950377f9efad6129a49c594bcd9a68a
Summary:In facebook#5241 ide updated the version number to be a fake one so that people wouldn't send in PRs just bumping the version. Unfortunately, this leads to compatibility issues when developing against `master` with 3rd-party components that declare React Native as a `peerDependency`. For example, I'm using [react-native-orientation](https://github.com/yamill/react-native-orientation) which has a peerDependency of `"react-native": ">=0.5"`. I see a few ways to deal with this: 1. Only develop against the releases on npm, not git snapshots. 2. Ask ecosystem projects to not include a minimum version of `react-native` in their peerDependencies. 3. Track the RN release numbers in the git repository (eg it would be 0.19 right now). 4. Make the release number on master huge (1000 in this PR) so it's obviously a fake number but will still comply with >= checks. I don't think option 2 is good because it's reasonable for a package author to want to specify a minimum R Closes facebook#5556 Differential Revision: D3110274 fb-gh-sync-id: 8638157d44ee99945337fbf585936b50699f0341 fbshipit-source-id: 8638157d44ee99945337fbf585936b50699f0341
Summary:Adding an app to showcase. Closes facebook#6709 Differential Revision: D3110665 fb-gh-sync-id: 5589799460588d7704d50d86ba2d9e8e8c7e9c15 fbshipit-source-id: 5589799460588d7704d50d86ba2d9e8e8c7e9c15
Summary:Allows you to keep versions, descriptions in sync Closes facebook#6576 Differential Revision: D3110926 fb-gh-sync-id: 7f1a2071feff5918e09f6c252ff9770f2f53130f fbshipit-source-id: 7f1a2071feff5918e09f6c252ff9770f2f53130f
Summary:This address the issue reported at facebook#6579 (comment) NavigationView should have the same API as NavigationAnimatedView does except that NavigationView does not need the APIs for animation. This unify the API of our core components so that people can freely compose views with both NavigationAnimatedView or NavigationView. Reviewed By: fkgozali Differential Revision: D3096076 fb-gh-sync-id: 7536777a7d637da62a2636d750f9d91c5a0eb45f fbshipit-source-id: 7536777a7d637da62a2636d750f9d91c5a0eb45f
Reviewed By: javache Differential Revision: D3107921 fb-gh-sync-id: 2982043280f925d390e4bebf3884d4762ac62cc6 fbshipit-source-id: 2982043280f925d390e4bebf3884d4762ac62cc6
Reviewed By: as106 Differential Revision: D3105839 fb-gh-sync-id: 24a8a215f65908b577891fb4b38366bad35cf6fc fbshipit-source-id: 24a8a215f65908b577891fb4b38366bad35cf6fc
Summary:and "not supported" warnings for ios Closes facebook#6400 Differential Revision: D3113988 fb-gh-sync-id: 169623f157ec59c38b4368cbc668c85201b67ed8 fbshipit-source-id: 169623f157ec59c38b4368cbc668c85201b67ed8
Reviewed By: bestander Differential Revision: D3114557 fb-gh-sync-id: 7e519f6304efc4ce17e5751ef65c5b4fac2baf5f fbshipit-source-id: 7e519f6304efc4ce17e5751ef65c5b4fac2baf5f
…en over the status bar Summary:The navigation drawer of most apps on android opens over the status bar, this adds an option to do so. It implements a similar API to the native DrawerLayout by adding a statusBarBackgroundColor to DrawerLayoutAndroid. Without statusBarBackgroundColor:  With statusBarBackgroundColor:  This PR depends on the changes in facebook#6195 to add the `StatusBar.HEIGHT` constant I just want to put it out there now to see if this looks good. To test without the other PR just change `StatusBar.HEIGHT` for `25`. It is implemented by making the native status bar translucent and making its background color transparent so we can draw a view of the same height as the status bar under it as a child of the DrawerLayoutAndroid. Then we can draw a semi-transparent gray View inside the drawer view to make it Closes facebook#6218 Differential Revision: D3017444 Pulled By: bestander fb-gh-sync-id: ca48a47a20a2feecae360a76f3e2c9bbe6a37700 fbshipit-source-id: ca48a47a20a2feecae360a76f3e2c9bbe6a37700
Summary:cc bestander Closes facebook#6705 Reviewed By: mkonicek Differential Revision: D3114562 Pulled By: bestander fb-gh-sync-id: ca9b3af99394f3883c9f7cd7c462b699c4d8ca95 fbshipit-source-id: ca9b3af99394f3883c9f7cd7c462b699c4d8ca95
Reviewed By: bestander Differential Revision: D3113371 fb-gh-sync-id: 96c8cbad2439a53259b47e6be11654148384aabc fbshipit-source-id: 96c8cbad2439a53259b47e6be11654148384aabc
Summary:Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: (You can skip this if you're fixing a typo or adding an app to the Showcase.) Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). Closes facebook#6718 Differential Revision: D3114873 fb-gh-sync-id: 26c4a3c80ba9e2e346663cc6ca58850fb55b977d fbshipit-source-id: 26c4a3c80ba9e2e346663cc6ca58850fb55b977d
Summary:`flowIDMap` lives on the bridge to map from the IDs used for the flow events in JS and the ones generated by `RCTProfile` in the native side. It was being accessed from multiple threads (the various modules' queues in the bridge and the JS thread), so we lock before touching it. Reviewed By: javache Differential Revision: D3102745 fb-gh-sync-id: 93d012d124e8b5d1a390c10a98ef5e3a068ccf63 fbshipit-source-id: 93d012d124e8b5d1a390c10a98ef5e3a068ccf63
Summary:We were calling `CFRunLoopStop` from `-dealloc` in the `JSCExecutor`, but dealloc is not guaranteed to run in the same thread. Move it to `-invalidate` instead. Reviewed By: javache Differential Revision: D3092645 fb-gh-sync-id: 94b51fec4a9fe0784feeb83d1b0c41de1cd7c052 fbshipit-source-id: 94b51fec4a9fe0784feeb83d1b0c41de1cd7c052
Summary: Closes facebook#6724 Differential Revision: D3115214 fb-gh-sync-id: 2b97ed162c15d8e6ad4ce4906a8b6fcba44864ca fbshipit-source-id: 2b97ed162c15d8e6ad4ce4906a8b6fcba44864ca
Summary:The packager url for the persistent connection relied on a port in the bundleURL, so we need to insert a sensible default. Otherwise, issues occur: facebook#6581 Reviewed By: bestander Differential Revision: D3113034 fb-gh-sync-id: 4eac52631ad7abd343b75a4488bb591b5caf2145 fbshipit-source-id: 4eac52631ad7abd343b75a4488bb591b5caf2145
Reviewed By: javache Differential Revision: D3115208 fb-gh-sync-id: c0fef5a162ab023d55736b38c51c87b8759f089d fbshipit-source-id: c0fef5a162ab023d55736b38c51c87b8759f089d
Summary: We lost java module and method names in systrace when we moved to the xplat bridge. Reviewed By: mhorowitz Differential Revision: D3116042 fb-gh-sync-id: a61181f4d6be04c70122b7f79d426e364df1e988 fbshipit-source-id: a61181f4d6be04c70122b7f79d426e364df1e988
Reviewed By: rnystrom Differential Revision: D3117661 fb-gh-sync-id: 05b7f796b58656aa13e4be78a562e07d18cf9488 fbshipit-source-id: 05b7f796b58656aa13e4be78a562e07d18cf9488
…void overdraw Reviewed By: foghina Differential Revision: D3079290 fb-gh-sync-id: b824d235ca34f8e0408f5f40e6b73e028006ac9f fbshipit-source-id: b824d235ca34f8e0408f5f40e6b73e028006ac9f
Summary:Updated docs:  Closes facebook#6685 Differential Revision: D3119791 Pulled By: javache fb-gh-sync-id: fadd5ea1a1b979f79b41c80b6a19fdb9ea3f100f fbshipit-source-id: fadd5ea1a1b979f79b41c80b6a19fdb9ea3f100f
Summary:This reverts "Android support for perspective transform": 3e760f4, PR facebook#6159, D3053532. It broke negative scale transforms: facebook#6622 Reviewed By: bestander Differential Revision: D3120627 fb-gh-sync-id: 727528d39c049180fe4862d006f2089c997afd45 fbshipit-source-id: 727528d39c049180fe4862d006f2089c997afd45
Summary:mkonicek how can I add a line break to that? Closes facebook#6742 Differential Revision: D3120662 fb-gh-sync-id: 292ff3ae35c7ba4f583d3d3d4d5993812823e112 fbshipit-source-id: 292ff3ae35c7ba4f583d3d3d4d5993812823e112
Summary:Creating views shouldn't have side effects so we can start doing them before the end of a batch. In order to limit the effect on framerate, we stop executing these create view operations after we've passed halfway through the frame. Note, this doesn't seem to work yet for nodes: I'll address that in a followup diff. Reviewed By: lexs Differential Revision: D3120631 fb-gh-sync-id: 981540fac5a7499158146adb72c1be21fd0b5702 fbshipit-source-id: 981540fac5a7499158146adb72c1be21fd0b5702
Summary:Show my app : Helium Helium is an app where people can discover the best of what others are up to in their free time . Closes facebook#7035 Differential Revision: D3191805 Pulled By: mkonicek fb-gh-sync-id: 03117821a6bce1924415b68df9ad8a2770acb930 fbshipit-source-id: 03117821a6bce1924415b68df9ad8a2770acb930
Summary:- Get rid of no longer necessary WebSocket.js v WebSocketBase.js split - Use `EventTarget(list, of, events)` as base class to auto-generate `oneventname` getters/setters that get invoked along with other event handlers - Type annotation `any` considered harmful, especially when we can easily spell out the actual type - Throw in some `const` goodness for free **Test Plan:** Launch UIExplorer example app, supplied `websocket_test_server` script, and try different combinations of sending and receiving text and binary data on both iOS and Android. Closes facebook#6889 Differential Revision: D3184835 Pulled By: mkonicek fb-gh-sync-id: f21707f4e97aa5a79847f5157e0a9f132a1a01cd fbshipit-source-id: f21707f4e97aa5a79847f5157e0a9f132a1a01cd
Summary: Closes facebook#7045 Differential Revision: D3194558 fb-gh-sync-id: 57691d4d54bbe2bdce6abf885b6aa0f341f12644 fbshipit-source-id: 57691d4d54bbe2bdce6abf885b6aa0f341f12644
Summary: This error message is remarkably aggressive relative to the severity of the issue, particularly since the pattern in question is used / necessary throughout the codebase. Animated ReactART components with set opacities trigger this error, and opacity coming from the style prop is not respected. Reviewed By: sahrens Differential Revision: D3177554 fb-gh-sync-id: 96061d5ff526177814996b28e4394e6649839582 fbshipit-source-id: 96061d5ff526177814996b28e4394e6649839582
kmagiera
force-pushed
the
nativeanim_rough
branch
2 times, most recently
from
327c9ca
to
31e05c0
Compare
Summary:This change adds suport native animated support for Animated.add. Animated.add lets you declare node that outputs a sum of it input nodes. **Test Plan** Play with the following playground app: https://gist.github.com/39de37faf07480fcd7d1 Run JS tests: `npm test Libraries/Animated/src/__tests__/AnimatedNative-test.js` Run java tests: `buck test ReactAndroid/src/test/java/com/facebook/react/animated` Closes facebook#6641 Differential Revision: D3195963 fb-gh-sync-id: bb1e1a36821a0e071ad0e7d0fa99ce0d6b088b0a fbshipit-source-id: bb1e1a36821a0e071ad0e7d0fa99ce0d6b088b0a
Summary:The WebView component in iOS currently does not support displaying PDFs without providing a remote URI or manually including the assets in the xcodeproj itself. This is because the packager has not whitelisted the 'pdf' extension. I've gone ahead and whitelisted the 'pdf extension according to the recommendation by nicklockwood GH comment: facebook#1846 (comment) Closes facebook#7004 Differential Revision: D3196019 Pulled By: nicklockwood fb-gh-sync-id: 10a86a9232095f98f277506141de0b8af5b21ab4 fbshipit-source-id: 10a86a9232095f98f277506141de0b8af5b21ab4
Summary: Under some circumstances, the calloutIndex might be > number of callout views, (possibly due to a race condition?). This prevents that from crashing. Reviewed By: tadeuzagallo Differential Revision: D3196010 fb-gh-sync-id: 6485e64c682937431cb8598d7f3f42e8d37eeff1 fbshipit-source-id: 6485e64c682937431cb8598d7f3f42e8d37eeff1
Summary:Fixes warnings when React API is used by requiring 'react-native'. Closes facebook#7060 Differential Revision: D3196109 Pulled By: mkonicek fb-gh-sync-id: b47afc138cd7909ad53c0d67a65e3a124b87134b fbshipit-source-id: b47afc138cd7909ad53c0d67a65e3a124b87134b
Summary:Quite a few updates, some of them were mainly styling ones (please tell me to either revert them or update if they do not match the style guide!). Clarified test steps and improved release scripts so that they are easier to read. I have also removed a note about tags and CircleCi pushing a release since that's already done for us by a `update-oss-version`. Another update is that we now mention steps to check that are printed by `test-manual-e2e.sh` as I have noticed they were recently updated, so better to just clarify they are printed out. Closes facebook#7041 Differential Revision: D3196122 Pulled By: mkonicek fb-gh-sync-id: d3f87e6340ef3cddd4719902a05231072f05a287 fbshipit-source-id: d3f87e6340ef3cddd4719902a05231072f05a287
Summary:Appetize asked for this so they can better support us, since they will usually have more simulators available for the latest versions. Closes facebook#7061 Differential Revision: D3196110 Pulled By: mkonicek fb-gh-sync-id: 2406ab6e1ee352f0148957e851d7f483a2182f90 fbshipit-source-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
Summary:added app to website/showcase.js that is built with React Native. Closes facebook#7018 Differential Revision: D3196127 Pulled By: mkonicek fb-gh-sync-id: e4f29f00eaf2f8cd1eab53fe83822c6480baa511 fbshipit-source-id: e4f29f00eaf2f8cd1eab53fe83822c6480baa511
Summary:Rookie mistake I made. **Test plan (required)** See that https://circleci.com/gh/facebook/react-native/5462 succeeds deploying the website correctly. Closes facebook#7063 Differential Revision: D3196198 fb-gh-sync-id: 14fdc94fad0b1e5ff74cc90bb89d2bd1bf29bfa3 fbshipit-source-id: 14fdc94fad0b1e5ff74cc90bb89d2bd1bf29bfa3
Summary:Emoji Poetry app for showcase page Closes facebook#6879 Differential Revision: D3196123 fb-gh-sync-id: f9db698c64c7d9077ce359f28d6dd10ff49f7d8b fbshipit-source-id: f9db698c64c7d9077ce359f28d6dd10ff49f7d8b
Summary:This fixes the error `undefined is not an object (evaluating 'this.refs[NATIVE_REF].setNativeProps')`, which seems to occur when the refresh fails (in our case due to CORS).  Closes facebook#6489 Differential Revision: D3172217 fb-gh-sync-id: 5ba3b2653685888f5358ef32b01b441757eff7c8 fbshipit-source-id: 5ba3b2653685888f5358ef32b01b441757eff7c8
Reviewed By: andreicoman11 Differential Revision: D3192529 fb-gh-sync-id: 4ea5d9d3e3b4f435e86a5dba4ddb7812f8d00fbc fbshipit-source-id: 4ea5d9d3e3b4f435e86a5dba4ddb7812f8d00fbc
Summary:The require functions will keep the generate bytecode + lexical environment in memory unnecessarily, since we can be sure that it will be executed at most once Reviewed By: davidaurelio Differential Revision: D3168257 fb-gh-sync-id: 038e1bc08abea94ee52d0390b6aced5fb652f493 fbshipit-source-id: 038e1bc08abea94ee52d0390b6aced5fb652f493
Summary:Added new app in showcase.js Closes facebook#6912 Differential Revision: D3196473 fb-gh-sync-id: 8c06763907e5bf998c0f0edd832fd1f032ece35c fbshipit-source-id: 8c06763907e5bf998c0f0edd832fd1f032ece35c
This change extends animated native module API with `stopAnimation` method that is responsible for interrupting actively running animation as a reslut of a JS call. In order for the `stopAnimation` to understand `animationId` argument I also had to add `animationId` to `startAnimation` method. As JS thread runs in parallel to the thread which executes the animation there is a chance that JS may call `stopAnimation` after the animation has finished. Because of that we are not doing any checks on the `animationId` parameter passed to `stopAnimation` in native and if the animation does not exists in the registry we ignore that call. **Test Plan** Run JS tests: `npm test Libraries/Animated/src/__tests__/AnimatedNative-test.js` Run java tests: `buck test ReactAndroid/src/test/java/com/facebook/react/animated`
kmagiera
force-pushed
the
nativeanim_rough
branch
from
31e05c0
to
738466f
Compare
Kudo
pushed a commit
that referenced
this pull request
Feb 17, 2022
Summary: Previous iterations of this diff that were reverted: D30678341 (facebook@8009459), D30868627 (facebook@abd0f38), D31024459 (facebook@0a46e5e). With the power of selects, we can move the base AppleTVOS flags into the regular base Apple flags. Changelog: [Internal] Reviewed By: mzlee Differential Revision: D31147242 fbshipit-source-id: deef1f1b39eb21772ab7ddd2ef1f19814e1f72d5
Kudo
pushed a commit
that referenced
this pull request
Feb 17, 2022
…ake #4) Differential Revision: D31147242 (facebook@92c1bee) Original commit changeset: deef1f1b39eb fbshipit-source-id: d4d3c7546e4e2bcf59a72c7c865ee7d9218ab0d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.