Have CocoaPods read some values from package.json #6576
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@nevir updated the pull request. |
1 similar comment
|
@nevir updated the pull request. |
Allows you to keep versions, descriptions in sync
|
@nevir updated the pull request. |
| Pod::Spec.new do |s| | ||
| s.name = "React" | ||
| s.version = "0.0.1-master" | ||
| s.summary = "Build high quality mobile apps using React." | ||
| s.version = package['version'].start_with?('0.0.0') ? '0.0.1-master' : package['version'] |
There was a problem hiding this comment.
We very recently changed (or plan to change) package.json to be version "1000.0.0" in master, so just package['version'] should suffice
There was a problem hiding this comment.
Still not in master FYI - but SGTM!
|
Thanks, this looks great and should simplify maintenance. |
|
@nevir updated the pull request. |
|
The version in the podspec file needs to be greater than 0. See this PR #6381. Is there a problem if the version specified on the package.json changes to |
|
See #6576 (comment); if we still want that behavior, though, I can drop the 2nd commit |
|
#5556 has landed (bumps version to 1000.0.0 in master), let's give this a shot |
|
@facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
Summary:Allows you to keep versions, descriptions in sync Closes facebook#6576 Differential Revision: D3110926 fb-gh-sync-id: 7f1a2071feff5918e09f6c252ff9770f2f53130f fbshipit-source-id: 7f1a2071feff5918e09f6c252ff9770f2f53130f
Allows you to keep versions, descriptions in sync