Updates to release notes #7041
Closed
Updates to release notes #7041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite a few updates, some of them were mainly styling ones (please tell me to either revert them or update if they do not match the style guide!). Clarified test steps and improved release scripts so that they are easier to read. I have also removed a note about tags and CircleCi pushing a release since that's already done for us by a `update-oss-version`. Another update is that we now mention steps to check that are printed by `test-manual-e2e.sh` as I have noticed they were recently updated, so better to just clarify they are printed out.
|
By analyzing the blame information on this pull request, we identified @mkonicek and @bestander to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@grabbou updated the pull request. |
|
@grabbou updated the pull request. |
|
That is very nice, thanks for doing this |
|
@grabbou updated the pull request. |
I would just go and follow steps section by section (and pre-release is mentioned only at the end when we are about to do the stable release).
|
@grabbou updated the pull request. |
|
Thanks @bestander @mkonicek I've also added a note about making a release notes, esp. to double check commit messages and reword them when appropriate. |
|
Looks great, thanks a lot @grabbou! @facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
ptmt
pushed a commit
to ptmt/react-native
that referenced
this pull request
May 9, 2016
Summary:Quite a few updates, some of them were mainly styling ones (please tell me to either revert them or update if they do not match the style guide!). Clarified test steps and improved release scripts so that they are easier to read. I have also removed a note about tags and CircleCi pushing a release since that's already done for us by a `update-oss-version`. Another update is that we now mention steps to check that are printed by `test-manual-e2e.sh` as I have noticed they were recently updated, so better to just clarify they are printed out. Closes facebook#7041 Differential Revision: D3196122 Pulled By: mkonicek fb-gh-sync-id: d3f87e6340ef3cddd4719902a05231072f05a287 fbshipit-source-id: d3f87e6340ef3cddd4719902a05231072f05a287
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:Quite a few updates, some of them were mainly styling ones (please tell me to either revert them or update if they do not match the style guide!). Clarified test steps and improved release scripts so that they are easier to read. I have also removed a note about tags and CircleCi pushing a release since that's already done for us by a `update-oss-version`. Another update is that we now mention steps to check that are printed by `test-manual-e2e.sh` as I have noticed they were recently updated, so better to just clarify they are printed out. Closes facebook#7041 Differential Revision: D3196122 Pulled By: mkonicek fb-gh-sync-id: d3f87e6340ef3cddd4719902a05231072f05a287 fbshipit-source-id: d3f87e6340ef3cddd4719902a05231072f05a287
samerce
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary:Quite a few updates, some of them were mainly styling ones (please tell me to either revert them or update if they do not match the style guide!). Clarified test steps and improved release scripts so that they are easier to read. I have also removed a note about tags and CircleCi pushing a release since that's already done for us by a `update-oss-version`. Another update is that we now mention steps to check that are printed by `test-manual-e2e.sh` as I have noticed they were recently updated, so better to just clarify they are printed out. Closes facebook#7041 Differential Revision: D3196122 Pulled By: mkonicek fb-gh-sync-id: d3f87e6340ef3cddd4719902a05231072f05a287 fbshipit-source-id: d3f87e6340ef3cddd4719902a05231072f05a287
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few updates, some of them were mainly styling ones (please tell me to either revert them or update if they do not match the style guide!).
Clarified test steps and improved release scripts so that they are easier to read.
I have also removed a note about tags and CircleCi pushing a release since that's already done for us by a
update-oss-version.Another update is that we now mention steps to check that are printed by
test-manual-e2e.shas I have noticed they were recently updated, so better to just clarify they are printed out.