Fix red screen due to ref being undefined in PullRefreshViewAndroid #6489

thomdixon · 2016-03-16T19:37:29Z

This fixes the error
undefined is not an object (evaluating 'this.refs[NATIVE_REF].setNativeProps'), which seems to occur when the refresh fails (in our case due to CORS).

facebook-github-bot · 2016-03-16T19:38:26Z

By analyzing the blame information on this pull request, we identified @jaysoo, @bestander and @janicduplessis to be potential reviewers.

facebook-github-bot · 2016-03-16T19:38:27Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

facebook-github-bot · 2016-03-17T00:57:41Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

satya164 · 2016-04-04T16:14:44Z

Libraries/PullToRefresh/PullToRefreshViewAndroid.android.js

@@ -67,7 +67,7 @@ var PullToRefreshViewAndroid = React.createClass({
  },

  setNativeProps: function(props) {
-    return this.refs[NATIVE_REF].setNativeProps(props);
+    return this.getInnerViewNode().setNativeProps(props);


Can you do the check here instead of doing it onRefresh?

facebook-github-bot · 2016-04-04T17:01:16Z

@thomdixon updated the pull request.

facebook-github-bot · 2016-04-04T17:01:23Z

@thomdixon updated the pull request.

thomdixon · 2016-04-04T17:41:10Z

@satya164 Done! Tests are failing because bestander/sinopia here on github can't be reached for some reason. Maybe you can run them again or run them locally?

satya164 · 2016-04-04T17:50:37Z

@thomdixon You can rebase on master to re-run the tests.

thomdixon · 2016-04-04T22:29:48Z

flow check is failing on some unrelated buck stuff. All other tests pass. Will run the tests again when I can. 🎱

satya164 · 2016-04-04T23:19:35Z

cc @bestander

The flow check seems to be failing due to some json files, which as I recall, was fixed with latest flow.

bestander · 2016-04-05T09:32:56Z

Thanks, @satya164, I have scheduled a rerun with clear caches.
Apparently there is a cached CI VM with buck installed in the same directory as the project.
This has been fixed for a few weeks already but we still get this cache loaded some times.

This fixes the error `undefined is not an object (evaluating 'this.refs[NATIVE_REF].setNativeProps')`.

@satya164

As requested by @satya164 :)

ide · 2016-04-05T19:36:21Z

Libraries/PullToRefresh/PullToRefreshViewAndroid.android.js

@@ -67,7 +67,8 @@ var PullToRefreshViewAndroid = React.createClass({
  },

  setNativeProps: function(props) {
-    return this.refs[NATIVE_REF].setNativeProps(props);
+    let innerViewNode = this.getInnerViewNode();
+    return innerViewNode && innerViewNode.setNativeProps(props);


When can innerViewNode be null? We should understand what's going on here and make sure that it's valid for setNativeProps to be called when innerViewNode is null, or instead fix whatever's calling setNativeProps at the wrong time.

ide · 2016-04-05T19:37:29Z

This looks like it's patching a symptom and not fixing the root cause. If this is a semantically correct fix, let's merge it, but I want to be sure first.

janicduplessis · 2016-04-12T07:27:32Z

Fixed something similar for RefreshControl. The ref is null if the PullToRefreshViewAndroid gets unmounted during the onRefresh callback.

thomdixon · 2016-04-13T00:56:57Z

@ide can we merge this, since you merged the iOS patch that basically does the same thing? Or would you like a revision? Thanks!

ide · 2016-04-13T01:14:07Z

Taking another look rn

ide · 2016-04-13T01:15:46Z

Thanks for the fix. We need support for asynchrony in React :/

@facebook-github-bot shipit

facebook-github-bot · 2016-04-13T01:18:21Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

bestander · 2016-04-19T13:01:59Z

@facebook-github-bot shipit

facebook-github-bot · 2016-04-19T13:05:50Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

Summary:This fixes the error `undefined is not an object (evaluating 'this.refs[NATIVE_REF].setNativeProps')`, which seems to occur when the refresh fails (in our case due to CORS). ![screen shot 2016-03-16 at 12 23 52](https://cloud.githubusercontent.com/assets/461514/13826121/1f8b0aaa-eb73-11e5-81e3-b2c60e536bf0.png) Closes facebook#6489 Differential Revision: D3172217 fb-gh-sync-id: 5ba3b2653685888f5358ef32b01b441757eff7c8 fbshipit-source-id: 5ba3b2653685888f5358ef32b01b441757eff7c8

facebook-github-bot added the GH Review: review-needed label Mar 16, 2016

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2016

satya164 reviewed Apr 4, 2016
View reviewed changes

thomdixon force-pushed the patch-1 branch from 3bce3c5 to 33c383f Compare April 4, 2016 17:03

thomdixon force-pushed the patch-1 branch from 33c383f to e93f833 Compare April 4, 2016 21:27

thomdixon added 2 commits April 5, 2016 09:33

Fix red screen due to ref being undefined

54699be

This fixes the error `undefined is not an object (evaluating 'this.refs[NATIVE_REF].setNativeProps')`.

Move ref check to setNativeProps from _onRefresh

ed787ab

As requested by @satya164 :)

thomdixon force-pushed the patch-1 branch from e93f833 to ed787ab Compare April 5, 2016 16:34

ide reviewed Apr 5, 2016
View reviewed changes

ide added GH Review: needs-revision and removed GH Review: review-needed labels Apr 5, 2016

janicduplessis mentioned this pull request Apr 12, 2016

RefreshControl broken on iOS on react-native 0.24.0-rc3 #6929

Closed

facebook-github-bot added GH Review: accepted and removed GH Review: needs-revision labels Apr 13, 2016

mkonicek added Import Failed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Apr 14, 2016

ghost closed this in d586daa Apr 19, 2016

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix red screen due to ref being undefined in PullRefreshViewAndroid #6489

Fix red screen due to ref being undefined in PullRefreshViewAndroid #6489

thomdixon commented Mar 16, 2016

facebook-github-bot commented Mar 16, 2016

facebook-github-bot commented Mar 16, 2016

facebook-github-bot commented Mar 17, 2016

satya164 Apr 4, 2016

facebook-github-bot commented Apr 4, 2016

facebook-github-bot commented Apr 4, 2016

thomdixon commented Apr 4, 2016

satya164 commented Apr 4, 2016

thomdixon commented Apr 4, 2016

satya164 commented Apr 4, 2016

bestander commented Apr 5, 2016

ide Apr 5, 2016

ide commented Apr 5, 2016

janicduplessis commented Apr 12, 2016

thomdixon commented Apr 13, 2016

ide commented Apr 13, 2016

ide commented Apr 13, 2016

facebook-github-bot commented Apr 13, 2016

bestander commented Apr 19, 2016

facebook-github-bot commented Apr 19, 2016

Fix red screen due to ref being undefined in PullRefreshViewAndroid #6489

Fix red screen due to ref being undefined in PullRefreshViewAndroid #6489

Conversation

thomdixon commented Mar 16, 2016

facebook-github-bot commented Mar 16, 2016

facebook-github-bot commented Mar 16, 2016

facebook-github-bot commented Mar 17, 2016

satya164 Apr 4, 2016

Choose a reason for hiding this comment

facebook-github-bot commented Apr 4, 2016

facebook-github-bot commented Apr 4, 2016

thomdixon commented Apr 4, 2016

satya164 commented Apr 4, 2016

thomdixon commented Apr 4, 2016

satya164 commented Apr 4, 2016

bestander commented Apr 5, 2016

ide Apr 5, 2016

Choose a reason for hiding this comment

ide commented Apr 5, 2016

janicduplessis commented Apr 12, 2016

thomdixon commented Apr 13, 2016

ide commented Apr 13, 2016

ide commented Apr 13, 2016

facebook-github-bot commented Apr 13, 2016

bestander commented Apr 19, 2016

facebook-github-bot commented Apr 19, 2016