Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty commit to start release 2.56.0 #5817

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Roger-Ethyca
Copy link
Contributor

@Roger-Ethyca Roger-Ethyca commented Feb 26, 2025

Pre-Release Steps

General

From the release branch, confirm the following:

  • Quickstart works: nox -s quickstart (verify you can complete the interactive prompts from the command-line)
  • Test environment works: nox -s "fides_env(test)" (verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)
  • Have Roger run a QATouch automation run

Next, run the following checks via the test environment:

API

CLI

Run these from within the test environment shell:

  • git reset --hard - Note: This is required for the pull command to work
  • fides user login
  • fides push src/fides/data/sample_project/sample_resources/
  • fides pull src/fides/data/sample_project/sample_resources/
  • fides evaluate src/fides/data/sample_project/sample_resources/
  • fides generate dataset db --credentials-id app_postgres test.yml - Note: Because the filesystem isn't mounted, the new file will only show up within the container
  • fides scan dataset db --credentials-id app_postgres

Privacy Center

  • Every navigation button works
  • DSR submission succeeds
  • Consent request submission succeeds

Admin UI

  • Every navigation button works
  • DSR approval succeeds
  • DSR execution succeeds

User Permissions

  • Verify user creation
  • Verify a Viewer can view all systems
  • Verify a Data Steward can edit systems they are assigned

Documentation

  • Verify that the CHANGELOG is formatted correctly and clean up verbiage where needed
  • Verify that the CHANGELOG is representative of the actual changes

⚠️ Note that any updates that need to be made to the CHANGELOG should not be commited directly to the release branch.
Instead, they should be committed on a branch off of main and then PR'd and merged into main, before being cherry-picked
over to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and main.

Publishing the release

When publishing the release, be sure to include the following sections in the release description:

  • ## Release Pull Request section that includes a link back to the release PR (i.e., this one!) for tracking purposes
  • ## QA Touch Test Run section that includes a link to the QATouch test run (QA team should provide this)

Post-Release Steps

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 2:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2025 2:21am

Copy link

cypress bot commented Feb 27, 2025

fides    Run #12616

Run Properties:  status check passed Passed #12616  •  git commit c43f2f2f15: Fix load_samples to correctly collect & load sample connections with "False" sec...
Project fides
Branch Review release-2.56.0
Run status status check passed Passed #12616
Run duration 00m 48s
Commit git commit c43f2f2f15: Fix load_samples to correctly collect & load sample connections with "False" sec...
Committer Neville Samuell
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

…tasks (#5820)

Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 32 lines in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (ed4346e) to head (c43f2f2).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...des/api/service/privacy_request/request_service.py 31.81% 30 Missing ⚠️
src/fides/api/db/samples.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5817       +/-   ##
===========================================
+ Coverage   71.15%   86.95%   +15.79%     
===========================================
  Files         405      406        +1     
  Lines       24949    25021       +72     
  Branches     2695     2695               
===========================================
+ Hits        17752    21756     +4004     
+ Misses       6667     2683     -3984     
- Partials      530      582       +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Eliana Rosselli <eliana@ethyca.com>
@erosselli erosselli added the do not merge Please don't merge yet, bad things will happen if you do label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Please don't merge yet, bad things will happen if you do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants