Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize DB access for terminated task check #5825

Merged
merged 6 commits into from
Feb 28, 2025

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Feb 28, 2025

Closes LJ-450

Description Of Changes

Updating the way we check for in progress request tasks to reduce the amount of DB reads

Code Changes

  • Adding tests

Steps to Confirm

  1. Follow steps from Re-queue interrupted Celery tasks #5800

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@galvana galvana requested a review from erosselli February 28, 2025 16:23
Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 5:18pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 5:18pm

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 14.70588% with 29 lines in your changes missing coverage. Please review.

Project coverage is 86.97%. Comparing base (1cf38cd) to head (636856a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...des/api/service/privacy_request/request_service.py 14.70% 29 Missing ⚠️

❌ Your patch status has failed because the patch coverage (14.70%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5825      +/-   ##
==========================================
- Coverage   86.99%   86.97%   -0.02%     
==========================================
  Files         407      407              
  Lines       25012    25021       +9     
  Branches     2697     2696       -1     
==========================================
+ Hits        21759    21762       +3     
- Misses       2670     2676       +6     
  Partials      583      583              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana merged commit a1d73ad into main Feb 28, 2025
37 of 38 checks passed
@galvana galvana deleted the tests-for-interrupted-task-requeue branch February 28, 2025 18:56
galvana added a commit that referenced this pull request Feb 28, 2025
Co-authored-by: Eliana Rosselli <eliana@ethyca.com>
Copy link

cypress bot commented Feb 28, 2025

fides    Run #12609

Run Properties:  status check passed Passed #12609  •  git commit a1d73ad38c: Optimize DB access for terminated task check (#5825)
Project fides
Branch Review main
Run status status check passed Passed #12609
Run duration 00m 49s
Commit git commit a1d73ad38c: Optimize DB access for terminated task check (#5825)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants