Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LJ-447 #5829

Merged
merged 4 commits into from
Mar 1, 2025
Merged

Fix LJ-447 #5829

merged 4 commits into from
Mar 1, 2025

Conversation

erosselli
Copy link
Contributor

@erosselli erosselli commented Feb 28, 2025

Description

This undos some changes made in commit 1cf38cd, which are breaking consent requests on fidesplus. I leave only the changes for the poll_for_exited_privacy_request_tasks which aren't breaking any flows, and rolled back all the changes related to the GraphTask code.

Steps to Confirm

  1. Fides runs ok and tests pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 0:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 1, 2025 0:38am

@erosselli erosselli changed the title Revert LJ-447 Fix LJ-447 Feb 28, 2025
@erosselli erosselli requested a review from galvana March 1, 2025 00:01
@erosselli erosselli added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Mar 1, 2025
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.94%. Comparing base (dfcb918) to head (c045250).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5829      +/-   ##
==========================================
- Coverage   86.97%   86.94%   -0.03%     
==========================================
  Files         407      406       -1     
  Lines       25021    25007      -14     
  Branches     2696     2695       -1     
==========================================
- Hits        21762    21743      -19     
- Misses       2676     2682       +6     
+ Partials      583      582       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erosselli erosselli merged commit 3924ebe into main Mar 1, 2025
41 checks passed
@erosselli erosselli deleted the revert-LJ-447 branch March 1, 2025 01:39
erosselli added a commit that referenced this pull request Mar 1, 2025
Copy link

cypress bot commented Mar 1, 2025

fides    Run #12613

Run Properties:  status check passed Passed #12613  •  git commit 3924ebe9d5: Fix LJ-447 (#5829)
Project fides
Branch Review main
Run status status check passed Passed #12613
Run duration 00m 50s
Commit git commit 3924ebe9d5: Fix LJ-447 (#5829)
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants