Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move system 'Assets' tab to be before 'History' #5826

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Feb 28, 2025

Closes unticketed

Description Of Changes

Moves "Assets" to be before "History" in the system form tabs; also fixes a bug in the new Ant tags where icons weren't showing up correctly.

Steps to Confirm

  1. View a system details page
  2. "Assets" should be before "History"
  3. Clicking any tab should append the appropriate hash to the URL
  4. Should be able to navigate to tabs by adding the appropriate hash

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:12pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:12pm

@@ -493,7 +493,7 @@ describe("System management with Plus features", () => {
});
});

describe("tab navigation", () => {
describe.only("tab navigation", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this on purpose?

@jpople jpople merged commit dfcb918 into main Feb 28, 2025
18 checks passed
@jpople jpople deleted the jpople/move-system-assets-tab branch February 28, 2025 19:28
Copy link

cypress bot commented Feb 28, 2025

fides    Run #12611

Run Properties:  status check passed Passed #12611  •  git commit dfcb91831d: Move system 'Assets' tab to be before 'History' (#5826)
Project fides
Branch Review main
Run status status check passed Passed #12611
Run duration 00m 52s
Commit git commit dfcb91831d: Move system 'Assets' tab to be before 'History' (#5826)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants