Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional group does not connect with another functional group on click&drag #1990

Closed
Zhirnoff opened this issue Dec 23, 2022 · 2 comments · Fixed by #2208
Closed

Functional group does not connect with another functional group on click&drag #1990

Zhirnoff opened this issue Dec 23, 2022 · 2 comments · Fixed by #2208
Assignees
@St-Permiakov
Labels
bug Priority: High
Milestone
Ketcher 2.9.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 23, 2022 •
edited
Loading

Steps to Reproduce

  1. Launch Ketcher
  2. Select any 'Functional Group' abbreviation (e.g. Bn)
  3. Place on canvas (do not expand)
  4. Select any 'Functional Group' abbreviation (e.g. Bn) with Template or Paste tools
  5. Hover over 'Bn' on canvas, click and drag

Actual behavior
At the moment, a notification window appears:
EDIT ABBREVIATION
A change was detected for the abbreviation. Do you want to remove the abbreviation information from the structure and continue work with separate atoms and bonds?

Expected behavior
If existing functional group is not yet connected to another structure, the new one should be added and connected with existing one with single bond.
2023-02-09_15h21_26

If existing functional group is already connected with another structure, 'Edit Abbreviation' dialog should be opened (current behavior).

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 108.0.5359.99 (Official Build) (64-bit)

Ketcher version
Version 2.7.0-rc.5
Build at 2022-12-22; 10:43:36

Additional context
Add any other context about the problem here.

#184100466
@Zhirnoff Zhirnoff added the bug label Dec 23, 2022
@Zhirnoff Zhirnoff added this to the Release 2.8.0 milestone Dec 23, 2022
@Nitvex
Copy link
Collaborator

Nitvex commented Jan 13, 2023

Issue is reproduced in v2.7.0-rc.9, moving to v2.9.0-rc.1

@KonstantinEpam23 KonstantinEpam23 assigned TimSPb89 and unassigned Nitvex Feb 1, 2023
@vanoprenko vanoprenko changed the title Functional Groups: Functional groups are not combined with a single bond Functional group does not connect with another functional group on click&drag Feb 9, 2023
St-Permiakov pushed a commit that referenced this issue Feb 13, 2023
#1990 - Detect if group is attached to smth + get attachment atom
42932dd
St-Permiakov pushed a commit that referenced this issue Feb 14, 2023
Merge branch 'master' into #1990-functional-group-does-not-connect-wi…
5de88ce 
…th-another-functional-group-on-clickdrag
St-Permiakov pushed a commit that referenced this issue Feb 14, 2023
#1990 - template tool mousedown() refactor
2984aed
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - Functional group does not connect with another functional gro…
7b74abd 
…up on click&drag
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
Merge remote-tracking branch 'origin/master' into #1990-functional-gr…
69a2568 
…oup-does-not-connect-with-another-functional-group-on-clickdrag
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - #2195 merge fixes
941319b
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - #2195 merge fixes
5d7b2a3
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - cleanup
8211e49
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - cleanup
3bed375
@St-Permiakov St-Permiakov linked a pull request Feb 16, 2023 that will close this issue
#1990: Functional group does not connect with another functional group on click&drag #2208
Merged
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - Detect if group is attached to smth + get attachment atom
3075830
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - hotfix
7ed9702
St-Permiakov added a commit that referenced this issue Feb 16, 2023
@St-Permiakov
#2229: Bond between Functional Group and structure disappears after a…
c736f77 
…dding Functional Group again (#2230)

* #1990 - Detect if group is attached to smth + get attachment atom

* #2229 - Bond between Functional Group and structure disappears after adding Functional Group again

* #2229 - rename pos0/pos1

* #2229 - more clear logic when replacing group

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
St-Permiakov added a commit that referenced this issue Feb 16, 2023
@St-Permiakov
#2229: Bond between Functional Group and structure disappears after a…
7f18a60 
…dding Functional Group again (#2230)

* #1990 - Detect if group is attached to smth + get attachment atom

* #2229 - Bond between Functional Group and structure disappears after adding Functional Group again

* #2229 - rename pos0/pos1

* #2229 - more clear logic when replacing group

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
St-Permiakov added a commit that referenced this issue Feb 16, 2023
@St-Permiakov
#2229: Bond between Functional Group and structure disappears after a…
67a0af0 
…dding Functional Group again (#2230) (#2231)

* #1990 - Detect if group is attached to smth + get attachment atom

* #2229 - Bond between Functional Group and structure disappears after adding Functional Group again

* #2229 - rename pos0/pos1

* #2229 - more clear logic when replacing group

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
Merge branch 'master' into #1990-functional-group-does-not-connect-wi…
022534e 
…th-another-functional-group-on-clickdrag
St-Permiakov pushed a commit that referenced this issue Feb 21, 2023
#1990 - fixes and clarifications after review
974c5c9
St-Permiakov pushed a commit that referenced this issue Feb 21, 2023
Merge branch 'master' into #1990-functional-group-does-not-connect-wi…
d4bb199 
…th-another-functional-group-on-clickdrag
St-Permiakov added a commit that referenced this issue Feb 21, 2023
@St-Permiakov
#1990: Functional group does not connect with another functional grou…
cb487e5 
…p on click&drag (#2208)

* #1990 - Detect if group is attached to smth + get attachment atom

* #1990 - template tool mousedown() refactor

* #1990 - Functional group does not connect with another functional group on click&drag

* #1990 - #2195 merge fixes

* #1990 - cleanup

* #1990 - hotfix

* #1990 - fixes and clarifications after review

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
ansivgit pushed a commit that referenced this issue Feb 22, 2023
@St-Permiakov @ansivgit
#2229: Bond between Functional Group and structure disappears after a…
fd99a90 
…dding Functional Group again (#2230) (#2231)

* #1990 - Detect if group is attached to smth + get attachment atom

* #2229 - Bond between Functional Group and structure disappears after adding Functional Group again

* #2229 - rename pos0/pos1

* #2229 - more clear logic when replacing group

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
ansivgit pushed a commit that referenced this issue Feb 22, 2023
@St-Permiakov @ansivgit
#1990: Functional group does not connect with another functional grou…
beb9651 
…p on click&drag (#2208)

* #1990 - Detect if group is attached to smth + get attachment atom

* #1990 - template tool mousedown() refactor

* #1990 - Functional group does not connect with another functional group on click&drag

* #1990 - #2195 merge fixes

* #1990 - cleanup

* #1990 - hotfix

* #1990 - fixes and clarifications after review

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
@yuleicul yuleicul mentioned this issue Feb 27, 2023
Closed
@yuleicul
Copy link
Collaborator

yuleicul commented Feb 28, 2023 •
edited
Loading

Expected behavior

......

If existing functional group is already connected with another structure, 'Edit Abbreviation' dialog should be opened (current behavior).

Could anyone please check if the expected behavior above has been achieved? If I understand correctly, it hasn't 😔. The 'Edit Abbreviation' dialog doesn't pop up as expected.

KonstantinEpam23 pushed a commit that referenced this issue Mar 10, 2023
@yuleicul @Nitvex
#1954 Draw selected structure at mouse cursor after closing Templates…
932733d 
… window (#2079)

* #1990 - Detect if group is attached to smth + get attachment atom

* #1990 - template tool mousedown() refactor

* #1990 - Functional group does not connect with another functional group on click&drag

* #1990 - #2195 merge fixes

* #1990 - cleanup

* #1990 - hotfix

* #1990 - fixes and clarifications after review

* #1954 - Draw selected structure at mouse cursor after closing Templates window

* #1954 - master merge hotfix

* #1954 – fixed tooltip appearance after adding functional group to canvas

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
This was referenced May 30, 2023
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@St-Permiakov St-Permiakov

Labels
bug Priority: High
Projects
None yet
Milestone
Ketcher 2.9.0-rc.1
Development

Successfully merging a pull request may close this issue.

#1990: Functional group does not connect with another functional group on click&drag epam/ketcher
5 participants
@St-Permiakov @yuleicul @TimSPb89 @Nitvex @Zhirnoff