Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When you click one Functional Group on another there is no replacement #2195

Closed
Zhirnoff opened this issue Feb 9, 2023 · 0 comments · Fixed by #2218 or #2223
Closed

When you click one Functional Group on another there is no replacement #2195

Zhirnoff opened this issue Feb 9, 2023 · 0 comments · Fixed by #2218 or #2223
Assignees
@TimSPb89
Labels
bug
Milestone
Ketcher 2.8.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 9, 2023 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher
  2. Select Functional Group (e.g. Bn) and place it on canvas
  3. Select Functional Group (e.g. Boc) and click on 'Bn'

Actual behavior
When you click one Functional Group on another, there is no replacement. Edit Abbreviation window appears

Expected behavior
One Functional Group is replaced by another. (e.g. 'Bn' replaces by 'Boc')

Screenshots

2023-02-09_15h19_19.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.8.0-rc.2
@Zhirnoff Zhirnoff added the bug label Feb 9, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.8.0-rc.3 milestone Feb 9, 2023
TimSPb89 added a commit that referenced this issue Feb 14, 2023
@TimSPb89
#2195 - When you click one Functional Group on another there is no re…
d3c79d6 
…placement - Fixed
@TimSPb89 TimSPb89 mentioned this issue Feb 14, 2023
Closed
TimSPb89 added a commit that referenced this issue Feb 14, 2023
@TimSPb89
#2195 - When you click one Functional Group on another there is no re…
2fdf2a9 
…placement - Fixed

+ small refactor in eraser tool to get rid of duplicated object
@TimSPb89 TimSPb89 mentioned this issue Feb 15, 2023
Merged
@Nitvex Nitvex linked a pull request Feb 15, 2023 that will close this issue
#2195: When you click one Functional Group on another there is no replacement #2218
Merged
Nitvex pushed a commit that referenced this issue Feb 15, 2023
@TimSPb89
#2195 - When you click one Functional Group on another there is no re…
f4b2ea5 
…placement - Fixed (#2218)

+ small refactor in eraser tool to get rid of duplicated object
Nitvex pushed a commit that referenced this issue Feb 15, 2023
@TimSPb89 @Nitvex
Backmerge: #2195 - When you click one Functional Group on another the…
898f1be 
…re is no replacement - Fixed (#2218)

+ small refactor in eraser tool to get rid of duplicated object
@Nitvex Nitvex mentioned this issue Feb 15, 2023
Merged
Nitvex added a commit that referenced this issue Feb 15, 2023
@Nitvex @TimSPb89
Backmerge: #2195 - When you click one Functional Group on another the…
8d1b4fb 
…re is no replacement - Fixed (#2218) (#2223)

+ small refactor in eraser tool to get rid of duplicated object

Co-authored-by: Tim Alyakin <31693137+TimSPb89@users.noreply.github.com>
@Zhirnoff Zhirnoff mentioned this issue Feb 15, 2023
Closed
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - #2195 merge fixes
941319b
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#1990 - #2195 merge fixes
5d7b2a3
St-Permiakov added a commit that referenced this issue Feb 21, 2023
@St-Permiakov
#1990: Functional group does not connect with another functional grou…
cb487e5 
…p on click&drag (#2208)

* #1990 - Detect if group is attached to smth + get attachment atom

* #1990 - template tool mousedown() refactor

* #1990 - Functional group does not connect with another functional group on click&drag

* #1990 - #2195 merge fixes

* #1990 - cleanup

* #1990 - hotfix

* #1990 - fixes and clarifications after review

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
ansivgit pushed a commit that referenced this issue Feb 22, 2023
@Nitvex @TimSPb89 @ansivgit
Backmerge: #2195 - When you click one Functional Group on another the…
1c66a26 
…re is no replacement - Fixed (#2218) (#2223)

+ small refactor in eraser tool to get rid of duplicated object

Co-authored-by: Tim Alyakin <31693137+TimSPb89@users.noreply.github.com>
ansivgit pushed a commit that referenced this issue Feb 22, 2023
@St-Permiakov @ansivgit
#1990: Functional group does not connect with another functional grou…
beb9651 
…p on click&drag (#2208)

* #1990 - Detect if group is attached to smth + get attachment atom

* #1990 - template tool mousedown() refactor

* #1990 - Functional group does not connect with another functional group on click&drag

* #1990 - #2195 merge fixes

* #1990 - cleanup

* #1990 - hotfix

* #1990 - fixes and clarifications after review

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
KonstantinEpam23 pushed a commit that referenced this issue Mar 10, 2023
@yuleicul @Nitvex
#1954 Draw selected structure at mouse cursor after closing Templates…
932733d 
… window (#2079)

* #1990 - Detect if group is attached to smth + get attachment atom

* #1990 - template tool mousedown() refactor

* #1990 - Functional group does not connect with another functional group on click&drag

* #1990 - #2195 merge fixes

* #1990 - cleanup

* #1990 - hotfix

* #1990 - fixes and clarifications after review

* #1954 - Draw selected structure at mouse cursor after closing Templates window

* #1954 - master merge hotfix

* #1954 – fixed tooltip appearance after adding functional group to canvas

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimSPb89 TimSPb89

Labels
bug
Projects
None yet
Milestone
Ketcher 2.8.0-rc.3
3 participants
@TimSPb89 @Nitvex @Zhirnoff