#1954 Draw selected structure at mouse cursor after closing Templates window

[yuleicul]

Resolves #1954

To make the template tool consistent with the paste tool, I marked the previous implementation as deprecated instead of deleting it directly, in case the previous code is helpful to future work.

Bug collections

Bug	Status
#2079 (comment)	Convert to new issue #2114
#2079 (comment)	Convert to new issue #2113
#2079 (comment)	Resolved by #2087
#2079 (comment)	Redirect to #2091
#2079 (comment)	✅
#2079 (comment)	✅
#2079 (comment)	Convert to new issue #2110
#2079 (comment) 1	Redirect to #2109
#2079 (comment) 2	Convert to new issue #2110

Showcase

[yuleicul]

Indicated why.

[KonstantinEpam23]

Please note - there is a bit of an issue w/ Paste tool, if you want to select another tool with your mouse while hovering - it will move the scroll position. I dont think this is a particularly big issue, something to note though:

rec-paste-2.mov

[KonstantinEpam23]

Another edge-case issue w/ Paste tool (I dont think its that important, but good to know) - if you press Ctrl+S (save) on your keyboard - the structure that is being hovered will get into the saved molecule.

rec-paste.mov

[yuleicul]

Note another issue with Cut Tool and Copy Tool —— Functional Groups and Salts and Solvents can't be copied or cut.

[yuleicul]

Note one more, after selecting one of Functional Groups or Salts and Solvents, click Clear Canvas, an error occurs

[KonstantinEpam23]

Note one more, after selecting one of Functional Groups or Salts and Solvents, click Clear Canvas, an error occurs

btw, I cant reproduce this on master

[KonstantinEpam23]

Note another issue with Cut Tool and Copy Tool —— Functional Groups and Salts and Solvents can't be copied or cut.

looks like #2087 resolves this

[yuleicul]

(This bug has been fixed by commit 829fbf2 in this PR)

Bug: when pasting a salt or solvent next to another structure, it shouldn't be merged

Steps to Reproduce

1. Copy or cut a salt or solvent
2. Paste it to the canvas
3. Move your mouse close to other structures, until the green circle shows
4. Mouse up

Actual behavior
The salt or solvent merges with other structure

Expected behavior
In step 3, the green circle shouldn't be shown. And at last, the salt or solvent shouldn't be merged

Screenshots

[yuleicul]

(This bug has been fixed by commit 829fbf2 and 3afa70e in this PR)

Bug: Green hovered circle showing when moving salts and solvents close to other structures by select tool

Steps to Reproduce

1. Select a salt or solvent
2. Drag it close to other structures, until the green circle shows
3. Mouse up, and nothing will be merged

Actual behavior
Described above

Expected behavior
Because it's correct that the salt or solvent doesn't merge with other structures in step 3, it doesn't make sense that in step 2 the green circle shows. The expected behavior is the green circle shouldn't show.

Screenshots

[yuleicul]

This bug occurs after the two bugs above have been fixed. I guess It's a bit complicated to resolve. Consider creating a new ticket or maybe there are other tickets that are working on it.

Bug: Non-expanded functional group doesn't show the green merging circle because the circle is hidden in the functional group

Steps to Reproduce

1. Select a functional group
2. Drag it close to other structures

Actual behavior
The green circle doesn't show

Expected behavior
The green circle shows because it can be merged

Screenshots

[Nitvex]

In general, LGTM.
But the only thing I want to clarify – can't mergeMap include 'salt or solvents'?
From this function, I see it doesn't add salt or solvent to a map, but can't they be added before this function gets called? In lines 85-88, there new Map created from atoms and bonds of closestItem:

let mergeMap: MergeMap = {
    atoms: new Map(closestMap.atoms),
    bonds: new Map(closestMap.bonds)
  }

[yuleicul]

Really good suggestion. Have changed to call this function a bit earlier. Thank you!

[Nitvex]

Found a couple of problems:


To reproduce this:

1. Add benzene ring
2. Choose some salt or solvent
3. Put it exactly on some atom of benzene ring
   – Acetic acid is merged with benzene ring
   – Acetic acid was added twice
   – If click 'esc' and move mouse, then error in console is thrown

---

Other problem:

1. Add benzene ring
2. Choose some functional group
3. Put it exactly on some atom of benzene ring
   – Functional group is added twice
   – No green circle is shown, when hovering over atom

This is how it looks like, when adding only one functional group

Expected behaviour:
When hovering over an atom with functional group chosen:

After adding functional group:

[yuleicul]

Other problem:

1. Add benzene ring
2. Choose some functional group
3. Put it exactly on some atom of benzene ring
   – Functional group is added twice
   – No green circle is shown, when hovering over atom

This is how it looks like, when adding only one functional group

Expected behaviour: When hovering over an atom with functional group chosen: After adding functional group:

@Nitvex I suppose this one is complicated. I have created a new issue for it, see #2110

[yuleicul]

Found a couple of problems: To reproduce this:

1. Add benzene ring
2. Choose some salt or solvent
3. Put it exactly on some atom of benzene ring
   – Acetic acid is merged with benzene ring
   – Acetic acid was added twice
   – If click 'esc' and move mouse, then error in console is thrown

This one is redirected to #2109

[St-Permiakov]

Maybe we shouldn't separate testing for atoms and bonds involved in merge and cancel merge if there is any sign of salt or solvent at all.
But I'm not sure about all possible consequences, so it's just an assumption for now.

[KonstantinEpam23]

We might want to wait for #2110 and get back to re-implementing this

[KonstantinEpam23]

I can observe an issue where the tooltip appears for previous functional groups if you start inserting multiple ones. I believe this should be fixed before merging.

[KonstantinEpam23]

One more note - it seems to lag a bit when devtools are open and a benzene ring is following cursor around the canvas.