[BUGFIX beta] avoid ordered set deprecation #16709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good! I think we will also need to export this on the global (in |
savvymas
force-pushed
the
avoid-orderedset-deprecation
branch
from
8e15f56
to
a784a95
Compare
bekzod
reviewed
Jun 1, 2018
| export default class OrderedSet extends __OrderedSet__ { | ||
| constructor() { | ||
| super(); | ||
| deprecate('Use of @ember/OrderedSet is deprecated. Please use native `Map` instead', false, { |
There was a problem hiding this comment.
maybe it should say, Please use native Map or ember-ordered-set addon instead ?
There was a problem hiding this comment.
or "Please use native Map or https://github.com/emberjs/ember-ordered-set addon instead"
There was a problem hiding this comment.
This is a good idea and can be a followup PR
ef4
reviewed
Jun 1, 2018
| id: 'ember-map-deprecation', | ||
| until: '3.5.0', | ||
| }); | ||
| this.clear(); |
There was a problem hiding this comment.
Bug here -- this needs to stay in the base implementation.
savvymas
force-pushed
the
avoid-orderedset-deprecation
branch
from
a784a95
to
e5488e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a fix for this bug: emberjs/ember-ordered-set#19 by creating a private path that excludes the deprecation in the OrderedSet class.