@ember/ordered-set does not avoid deprecation warnings

[ef4]

My understanding of this addon is that people should switch to it to avoid deprecation warnings from the built-in ordered-set inside Ember. Which is what ember-data is doing here.

But using ember-data 3.1.1 (which is importing from @ember/ordered-set) with ember-canary we still get the deprecation. Presumably because @ember/ordered-set falls back to the built-in implementation in an effort not to bloat code size.

Do you want PRs to ember and ordered-set to create a deprecation-free private path?

cc @savvymas

[rwjblue]

My understanding of this addon is that people should switch to it to avoid deprecation warnings from the built-in ordered-set inside Ember.

👍

But using ember-data 3.1.1 (which is importing from @ember/ordered-set) with ember-canary we still get the deprecation. Presumably because falls back to the built-in implementation in an effort not to bloat code size.

Yes, that was exactly the goal. 🤔

Do you want PRs to ember and ordered-set to create a deprecation-free private path?

Yes, please 🙏 .

[rwjblue]

I think the most straightforward way to do this is:

• add via a private env flag (similar to this)
• Update the deprecation conditions here to check that private env flag (and suppress the deprecation when it is true)
• Add the flag to this addons config/environment.js (similar to this)

[ef4]

I think we don't want a global flag though -- anybody who is trying to use Ember.OrderedSet directly should still see a deprecation until they switch to using it via @ember/ordered-set.

[rwjblue]

@ef4 - Ahh, good point. In that case, I think we need to add the following to my steps above:

• Update the main module to have two exports, a non-deprecated (but private) base class and an extended class that adds the deprecation that exists today
• Update the main exports module to ensure that Ember.OrderedSet is using the deprecated class, and also add an Ember.__OrderedSet__
• Update this addons index.js to be OrderedSet = Ember.__OrderedSet__ || Ember.OrderedSet;

What do you think?

[ef4]

Yup, @savvymas is already embarking in that direction.