Merge pull request #16709 from savvymas/avoid-orderedset-deprecation

[BUGFIX beta] avoid ordered set deprecation
emberjs · Jun 1, 2018 · 6f1b060 · 6f1b060
2 parents 1bdb940 + e5488e2
commit 6f1b060
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 9 deletions.
diff --git a/packages/@ember/map/lib/ordered-set.js b/packages/@ember/map/lib/ordered-set.js
@@ -12,16 +12,17 @@ import { copyNull } from './utils';
   @constructor
   @private
 */
-export default class OrderedSet {
-  constructor() {
-    deprecate('Use of @ember/OrderedSet is deprecated. Please use native `Map` instead', false, {
-      id: 'ember-map-deprecation',
-      until: '3.5.0',
-    });
 
+/**
+ * This is exported so it can be used by the OrderedSet library.
+ * This is private do not use it.
+ @private
+ */
+
+export class __OrderedSet__ {
+  constructor() {
     this.clear();
   }
-
   /**
     @method create
     @static
@@ -166,3 +167,13 @@ export default class OrderedSet {
     return set;
   }
 }
+
+export default class OrderedSet extends __OrderedSet__ {
+  constructor() {
+    super();
+    deprecate('Use of @ember/OrderedSet is deprecated. Please use native `Map` instead', false, {
+      id: 'ember-map-deprecation',
+      until: '3.5.0',
+    });
+  }
+}
diff --git a/packages/@ember/map/tests/map_test.js b/packages/@ember/map/tests/map_test.js
@@ -1,6 +1,6 @@
 import Map from '..';
 import MapWithDefault from '../with-default';
-import OrderedSet from '../lib/ordered-set';
+import OrderedSet, { __OrderedSet__ } from '../lib/ordered-set';
 import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
 
 let object, number, string, map, variety;
@@ -566,3 +566,13 @@ moduleFor(
     }
   }
 );
+
+moduleFor(
+  '__OrderedSet__',
+  class extends AbstractTestCase {
+    ['@test private __OrderedSet__ can be created without deprecation']() {
+      expectNoDeprecation();
+      __OrderedSet__.create();
+    }
+  }
+);
diff --git a/packages/ember/index.js b/packages/ember/index.js
@@ -123,7 +123,7 @@ import Engine from '@ember/engine';
 import EngineInstance from '@ember/engine/instance';
 import Map from '@ember/map';
 import MapWithDefault from '@ember/map/with-default';
-import OrderedSet from '@ember/map/lib/ordered-set';
+import OrderedSet, { __OrderedSet__ } from '@ember/map/lib/ordered-set';
 import { assign, merge } from '@ember/polyfills';
 import {
   PROPERTY_WILL_CHANGE,
@@ -183,6 +183,7 @@ Ember.EngineInstance = EngineInstance;
 
 // ****@ember/map****
 Ember.OrderedSet = OrderedSet;
+Ember.__OrderedSet__ = __OrderedSet__;
 Ember.Map = Map;
 Ember.MapWithDefault = MapWithDefault;