Skip to content

Commit

Permalink
[BUGFIX beta] avoid ordered set deprecation
Browse files Browse the repository at this point in the history
  • Loading branch information
Savannah Mastrangelo authored and Savannah Mastrangelo committed Jun 1, 2018
1 parent ff6bc16 commit 8e15f56
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 9 deletions.
25 changes: 17 additions & 8 deletions packages/@ember/map/lib/ordered-set.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,14 @@ import { copyNull } from './utils';
@constructor
@private
*/
export default class OrderedSet {
constructor() {
deprecate('Use of @ember/OrderedSet is deprecated. Please use native `Map` instead', false, {
id: 'ember-map-deprecation',
until: '3.5.0',
});

this.clear();
}
/**
* This is exported so it can be used by the OrderedSet library.
* This is private do not use it.
@private
*/

export class __OrderedSet__ {
/**
@method create
@static
Expand Down Expand Up @@ -166,3 +164,14 @@ export default class OrderedSet {
return set;
}
}

export default class OrderedSet extends __OrderedSet__ {
constructor() {
super();
deprecate('Use of @ember/OrderedSet is deprecated. Please use native `Map` instead', false, {
id: 'ember-map-deprecation',
until: '3.5.0',
});
this.clear();
}
}
12 changes: 11 additions & 1 deletion packages/@ember/map/tests/map_test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Map from '..';
import MapWithDefault from '../with-default';
import OrderedSet from '../lib/ordered-set';
import OrderedSet, { __OrderedSet__ } from '../lib/ordered-set';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';

let object, number, string, map, variety;
Expand Down Expand Up @@ -566,3 +566,13 @@ moduleFor(
}
}
);

moduleFor(
'__OrderedSet__',
class extends AbstractTestCase {
['@test private __OrderedSet__ can be created without deprecation']() {
expectNoDeprecation();
__OrderedSet__.create();
}
}
);

0 comments on commit 8e15f56

Please sign in to comment.