-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change agent pprof default to false #1289
Change agent pprof default to false #1289
Conversation
A documentation preview will be available soon: |
I'll need to backport to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor fixes. Otherwise looks good. Thanks for updating the docs!
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending a clean build)
* Change agent pprof default to false * Apply suggestions from code review Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co>
* Change agent pprof default to false * Apply suggestions from code review Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co>
* Change agent pprof default to false * Apply suggestions from code review Co-authored-by: DeDe Morton <dede.morton@elastic.co> Co-authored-by: DeDe Morton <dede.morton@elastic.co>
As discussed in elastic/beats#29108 we will be changing the default
agent.monitoring.pprof
option to false.Behaviour of the option has also slightly changed to also apply to beats that the agent runs: elastic/beats#29155