Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change agent pprof default to false #1289

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Change agent pprof default to false #1289

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92a7e65
Change agent pprof default to false
michel-laterman Nov 25, 2021
03e1818
Apply suggestions from code review
michel-laterman Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ...ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ agent.monitoring:
logs: true
# enables metrics monitoring
metrics: true
# exposes /debug/pprof/ endpoints
# exposes /debug/pprof/ endpoints for agent and beats
michel-laterman marked this conversation as resolved.
Show resolved Hide resolved
# enable these endpoints if the monitoring endpoint is set to localhost
pprof: true
pprof: false
# specifies output to be used
use_output: monitoring
----
Expand All @@ -37,7 +37,8 @@ To enable monitoring, set `agent.monitoring.enabled` to `true`. Also set the
collected. If neither setting is specified, monitoring is turned off. Set
`use_output` to specify the output to which monitoring events are sent.

The `agent.monitoring.pprof` option controls whether the {agent} exposes the
`/debug/pprof/` endpoints with the monitoring endpoints. It is set to `true`
by default. If the monitoring endpoint is accessible over a network (not recommended),
set this option to `false` to disable the `/debug/pprof/` endpoints.
The `agent.monitoring.pprof` option controls whether the {agent} and {beats} exposes the
michel-laterman marked this conversation as resolved.
Show resolved Hide resolved
`/debug/pprof/` endpoints with the monitoring endpoints. It is set to `false`
by default. Data produced by these endpoints can be useful for debugging but present a
security risk. It is reccomended that this option remains `false` if the monitoring endpoint
is accessible over a network.
michel-laterman marked this conversation as resolved.
Show resolved Hide resolved