Skip to content

Commit

Permalink
Change agent pprof default to false (#1289)
Browse files Browse the repository at this point in the history
* Change agent pprof default to false

* Apply suggestions from code review

Co-authored-by: DeDe Morton <dede.morton@elastic.co>

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
  • Loading branch information
michel-laterman and dedemorton authored Nov 30, 2021
1 parent 27c47f4 commit 918792b
Showing 1 changed file with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ agent.monitoring:
logs: true
# enables metrics monitoring
metrics: true
# exposes /debug/pprof/ endpoints
# exposes /debug/pprof/ endpoints for Elastic Agent and Beats
# enable these endpoints if the monitoring endpoint is set to localhost
pprof: true
pprof: false
# specifies output to be used
use_output: monitoring
----
Expand All @@ -37,7 +37,8 @@ To enable monitoring, set `agent.monitoring.enabled` to `true`. Also set the
collected. If neither setting is specified, monitoring is turned off. Set
`use_output` to specify the output to which monitoring events are sent.

The `agent.monitoring.pprof` option controls whether the {agent} exposes the
`/debug/pprof/` endpoints with the monitoring endpoints. It is set to `true`
by default. If the monitoring endpoint is accessible over a network (not recommended),
set this option to `false` to disable the `/debug/pprof/` endpoints.
The `agent.monitoring.pprof` option controls whether the {agent} and {beats} expose the
`/debug/pprof/` endpoints with the monitoring endpoints. It is set to `false`
by default. Data produced by these endpoints can be useful for debugging but present a
security risk. It is recommended that this option remains `false` if the monitoring endpoint
is accessible over a network.

0 comments on commit 918792b

Please sign in to comment.