Change elastic-agent pprof default to false #29155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change agent.monitoring.pprof to false, allow it to toggle beat behaviour as well as the agent's.
michel-laterman
added
configuration
backport-v8.0.0
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
ruflin
approved these changes
Nov 29, 2021
| ) | ||
| if b.config.Pprof { |
There was a problem hiding this comment.
I know this is the way it works today but it is really ugly that we pass these things via cmd line params ...
There was a problem hiding this comment.
Yeah, we should change this in the future
|
/package |
|
/test |
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2021
Change agent.monitoring.pprof to false, allow it to toggle beat behaviour as well as the agent's. (cherry picked from commit 37b240a)
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2021
Change agent.monitoring.pprof to false, allow it to toggle beat behaviour as well as the agent's. (cherry picked from commit 37b240a)
michel-laterman
added a commit
that referenced
this pull request
Nov 30, 2021
michel-laterman
added a commit
that referenced
this pull request
Nov 30, 2021
elasticmachine
pushed a commit
to nxei/beats
that referenced
this pull request
Dec 1, 2021
* upstream/master: [libbeat] Fix add_labels flattening of arrays values (elastic#29211) Change elastic-agent pprof default to false (elastic#29155) elastic#28472 fix flaky tests in libbeat fmtstr to use time.UTC instead of time.Local (elastic#28473) Adopt `parsers` in Filebeat's journald input (elastic#29070) [Elastic Agent] Add process error handling guidelines (elastic#29152) winlogbeat/sys/winevent: use reflect IsZero method (elastic#29190) Remove Journalbeat (elastic#29131) Add note that there is no warranty or support for generator code (elastic#28797) packetbeat: preparation for npcap addition (elastic#29017) Use the generic helper for opening file to read in filestream (elastic#29180) Workflow for macos (elastic#29174) Fix `decode_json_fields` processor to always add error key (elastic#29107)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change agent.monitoring.pprof to false, allow it to toggle beat
behaviour as well as the agent's.
Checklist
I have commented my code, particularly in hard-to-understand areasI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues