Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern #73986

Merged
merged 2 commits into from
Jul 31, 2020
Merged

[Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern #73986

merged 2 commits into from
Jul 31, 2020

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jul 31, 2020 •
edited
Loading

Summary

This PR fixes #72529 by changing the fallback index pattern to metric* for any metricAlias that has multiple index patterns specified. If, for some reason, the metricAlias field is blank it will also use metric*.

How to test this PR

  1. Setup Metricbeat to index data from your local machine OR copy data using this script.
  2. Open Metrics Explorer
  3. Set the aggregation to Average and the metric field to system.cpu.user.pct
  4. Group by host.name
  5. On one for the charts, click on the Action menu and choose Open in visualize
  6. The charts should look similar (with data)
  7. Confirm that Index pattern under Panel options is set to metric*

Checklist

Delete any items that are not applicable to this PR.

Related issue in TSVB: #73987

@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 labels Jul 31, 2020
@simianhacker simianhacker requested a review from a team as a code owner July 31, 2020 18:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker simianhacker mentioned this pull request Jul 31, 2020
Closed
@simianhacker simianhacker added this to the Metrics UI 7.9 milestone Jul 31, 2020
Zacqary
Zacqary approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
infra 3.6MB +242.0B 3.6MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit 2e37239 into elastic:master Jul 31, 2020
@simianhacker simianhacker mentioned this pull request Jul 31, 2020
Merged
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jul 31, 2020
@simianhacker
[Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (…
6fa39eb 
…elastic#73986)

* [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern

* Adding link to TSVB bug to comment
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jul 31, 2020
@simianhacker
[Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (…
3bfcd86 
…elastic#73986)

* [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern

* Adding link to TSVB bug to comment
@simianhacker simianhacker mentioned this pull request Jul 31, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 2, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
dffcdf9 
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
simianhacker added a commit that referenced this pull request Aug 3, 2020
@simianhacker @elasticmachine
[Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (…
cbbe45d 
…#73986) (#74010)

* [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern

* Adding link to TSVB bug to comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
simianhacker added a commit that referenced this pull request Aug 3, 2020
@simianhacker @elasticmachine
[Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (…
1c2c3bc 
…#73986) (#74011)

* [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern

* Adding link to TSVB bug to comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@simianhacker simianhacker deleted the issue-72529-fix-tsvb-link-in-metrics-explorer branch April 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zacqary Zacqary Zacqary approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
Metrics UI 7.9
Development

Successfully merging this pull request may close these issues.

[Metrics UI] Open in visualize no longer works in Metrics Explorer
4 participants
@simianhacker @elasticmachine @kibanamachine @Zacqary