Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix timeline pin event callback #73981

Merged
merged 3 commits into from
Jul 31, 2020
Merged

[Security Solution] Fix timeline pin event callback #73981

merged 3 commits into from
Jul 31, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jul 31, 2020 •
edited by andrew-goldstein
Loading

Summary

Fixes a callback issue that prevented timeline events from being pinned in 7.9 BC5

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience Team:SIEM release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 31, 2020
@patrykkopycinski patrykkopycinski requested review from a team as code owners July 31, 2020 17:18
@patrykkopycinski patrykkopycinski self-assigned this Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

andrew-goldstein
andrew-goldstein approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @patrykkopycinski!
Desk tested locally
LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -65.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 5aca964 into elastic:master Jul 31, 2020
@patrykkopycinski patrykkopycinski deleted the fix/timeline-pin-event branch July 31, 2020 21:20
@patrykkopycinski patrykkopycinski mentioned this pull request Jul 31, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 31, 2020
@patrykkopycinski @andrew-goldstein
[Security Solution] Fix timeline pin event callback (elastic#73981)
d86b465 
* [Security Solution] Fix timeline pin event callback

* - added tests

* - restored the original disabled button behavior

Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>
@patrykkopycinski patrykkopycinski mentioned this pull request Jul 31, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 31, 2020
@patrykkopycinski @andrew-goldstein
[Security Solution] Fix timeline pin event callback (elastic#73981)
375774a 
* [Security Solution] Fix timeline pin event callback

* - added tests

* - restored the original disabled button behavior

Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>
patrykkopycinski added a commit that referenced this pull request Jul 31, 2020
@patrykkopycinski @andrew-goldstein
[Security Solution] Fix timeline pin event callback (#73981) (#74016)
18579f5 
* [Security Solution] Fix timeline pin event callback

* - added tests

* - restored the original disabled button behavior

Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>

Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>
patrykkopycinski added a commit that referenced this pull request Jul 31, 2020
@patrykkopycinski @andrew-goldstein
[Security Solution] Fix timeline pin event callback (#73981) (#74017)
b5c29f5 
* [Security Solution] Fix timeline pin event callback

* - added tests

* - restored the original disabled button behavior

Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>

Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 2, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
dffcdf9 
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @andrew-goldstein @MindyRS